From 5d3382f7a4c69a85e2aabbfa0c2b8b8e3f0574ae Mon Sep 17 00:00:00 2001
From: mufazalov <mufazalov@yandex-team.ru>
Date: Thu, 13 Feb 2025 15:50:27 +0300
Subject: [PATCH] fix(ObjectSummary): refresh tabs with tree refresh, disable
 autorefresh

---
 .../Tenant/ObjectSummary/ObjectSummary.tsx       | 16 +++++-----------
 .../SchemaTree/RefreshTreeButton.tsx             |  5 +++++
 .../Tenant/Schema/SchemaViewer/SchemaViewer.tsx  | 15 +++++++--------
 src/containers/Tenant/Tenant.tsx                 | 10 ++--------
 src/store/reducers/api.ts                        | 11 ++++++++++-
 src/store/reducers/overview/overview.ts          |  2 +-
 src/store/reducers/preview.ts                    |  2 +-
 src/store/reducers/schemaAcl/schemaAcl.ts        |  2 +-
 src/store/reducers/viewSchema/viewSchema.ts      |  2 +-
 9 files changed, 33 insertions(+), 32 deletions(-)

diff --git a/src/containers/Tenant/ObjectSummary/ObjectSummary.tsx b/src/containers/Tenant/ObjectSummary/ObjectSummary.tsx
index c71112932..313ab718d 100644
--- a/src/containers/Tenant/ObjectSummary/ObjectSummary.tsx
+++ b/src/containers/Tenant/ObjectSummary/ObjectSummary.tsx
@@ -24,7 +24,7 @@ import {
     formatNumber,
     formatSecondsToHours,
 } from '../../../utils/dataFormatters/dataFormatters';
-import {useAutoRefreshInterval, useTypedDispatch, useTypedSelector} from '../../../utils/hooks';
+import {useTypedDispatch, useTypedSelector} from '../../../utils/hooks';
 import {Acl} from '../Acl/Acl';
 import {EntityTitle} from '../EntityTitle/EntityTitle';
 import {SchemaViewer} from '../Schema/SchemaViewer/SchemaViewer';
@@ -76,7 +76,6 @@ export function ObjectSummary({
     onExpandSummary,
     isCollapsed,
 }: ObjectSummaryProps) {
-    const [autoRefreshInterval] = useAutoRefreshInterval();
     const dispatch = useTypedDispatch();
     const [, setCurrentPath] = useQueryParam('schema', StringParam);
     const [commonInfoVisibilityState, dispatchCommonInfoVisibilityState] = React.useReducer(
@@ -95,15 +94,10 @@ export function ObjectSummary({
         ignoreQueryPrefix: true,
     });
 
-    const {currentData: currentObjectData} = overviewApi.useGetOverviewQuery(
-        {
-            path,
-            database: tenantName,
-        },
-        {
-            pollingInterval: autoRefreshInterval,
-        },
-    );
+    const {currentData: currentObjectData} = overviewApi.useGetOverviewQuery({
+        path,
+        database: tenantName,
+    });
     const currentSchemaData = currentObjectData?.PathDescription?.Self;
 
     React.useEffect(() => {
diff --git a/src/containers/Tenant/ObjectSummary/SchemaTree/RefreshTreeButton.tsx b/src/containers/Tenant/ObjectSummary/SchemaTree/RefreshTreeButton.tsx
index f69bf8e34..34b1afc6b 100644
--- a/src/containers/Tenant/ObjectSummary/SchemaTree/RefreshTreeButton.tsx
+++ b/src/containers/Tenant/ObjectSummary/SchemaTree/RefreshTreeButton.tsx
@@ -2,11 +2,15 @@ import {ArrowsRotateLeft} from '@gravity-ui/icons';
 import {ActionTooltip, Button, Icon} from '@gravity-ui/uikit';
 import {nanoid} from '@reduxjs/toolkit';
 
+import {api} from '../../../../store/reducers/api';
+import {useTypedDispatch} from '../../../../utils/hooks';
 import {useDispatchTreeKey} from '../UpdateTreeContext';
 import {b} from '../shared';
 
 export function RefreshTreeButton() {
     const updateTreeKey = useDispatchTreeKey();
+    const dispatch = useTypedDispatch();
+
     return (
         <ActionTooltip title="Refresh">
             <Button
@@ -14,6 +18,7 @@ export function RefreshTreeButton() {
                 view="flat-secondary"
                 onClick={() => {
                     updateTreeKey(nanoid());
+                    dispatch(api.util.invalidateTags(['SchemaTree']));
                 }}
             >
                 <Icon data={ArrowsRotateLeft} />
diff --git a/src/containers/Tenant/Schema/SchemaViewer/SchemaViewer.tsx b/src/containers/Tenant/Schema/SchemaViewer/SchemaViewer.tsx
index 5361e04bf..916153bcf 100644
--- a/src/containers/Tenant/Schema/SchemaViewer/SchemaViewer.tsx
+++ b/src/containers/Tenant/Schema/SchemaViewer/SchemaViewer.tsx
@@ -38,20 +38,19 @@ interface SchemaViewerProps {
 
 export const SchemaViewer = ({type, path, tenantName, extended = false}: SchemaViewerProps) => {
     const [autoRefreshInterval] = useAutoRefreshInterval();
+
+    // Refresh table only in Diagnostics
+    const pollingInterval = extended ? autoRefreshInterval : undefined;
+
     const {currentData: schemaData, isLoading: loading} = overviewApi.useGetOverviewQuery(
-        {
-            path,
-            database: tenantName,
-        },
-        {
-            pollingInterval: autoRefreshInterval,
-        },
+        {path, database: tenantName},
+        {pollingInterval},
     );
 
     const viewSchemaRequestParams = isViewType(type) ? {path, database: tenantName} : skipToken;
 
     const {data: viewColumnsData, isLoading: isViewSchemaLoading} =
-        viewSchemaApi.useGetViewSchemaQuery(viewSchemaRequestParams);
+        viewSchemaApi.useGetViewSchemaQuery(viewSchemaRequestParams, {pollingInterval});
 
     const tableData = React.useMemo(() => {
         if (isViewType(type)) {
diff --git a/src/containers/Tenant/Tenant.tsx b/src/containers/Tenant/Tenant.tsx
index 172299672..4a1a5f8ae 100644
--- a/src/containers/Tenant/Tenant.tsx
+++ b/src/containers/Tenant/Tenant.tsx
@@ -12,7 +12,7 @@ import {selectSchemaObjectData} from '../../store/reducers/schema/schema';
 import type {AdditionalNodesProps, AdditionalTenantsProps} from '../../types/additionalProps';
 import {cn} from '../../utils/cn';
 import {DEFAULT_IS_TENANT_SUMMARY_COLLAPSED, DEFAULT_SIZE_TENANT_KEY} from '../../utils/constants';
-import {useAutoRefreshInterval, useTypedDispatch, useTypedSelector} from '../../utils/hooks';
+import {useTypedDispatch, useTypedSelector} from '../../utils/hooks';
 import {isAccessError} from '../../utils/response';
 
 import ObjectGeneral from './ObjectGeneral/ObjectGeneral';
@@ -43,7 +43,6 @@ interface TenantProps {
 }
 
 export function Tenant(props: TenantProps) {
-    const [autoRefreshInterval] = useAutoRefreshInterval();
     const [summaryVisibilityState, dispatchSummaryVisibilityAction] = React.useReducer(
         paneVisibilityToggleReducerCreator(DEFAULT_IS_TENANT_SUMMARY_COLLAPSED),
         undefined,
@@ -95,12 +94,7 @@ export function Tenant(props: TenantProps) {
         currentData: currentItem,
         error,
         isLoading,
-    } = overviewApi.useGetOverviewQuery(
-        {path, database: tenantName},
-        {
-            pollingInterval: autoRefreshInterval,
-        },
-    );
+    } = overviewApi.useGetOverviewQuery({path, database: tenantName});
 
     const preloadedData = useTypedSelector((state) =>
         selectSchemaObjectData(state, path, tenantName),
diff --git a/src/store/reducers/api.ts b/src/store/reducers/api.ts
index 27790d635..cb30066e4 100644
--- a/src/store/reducers/api.ts
+++ b/src/store/reducers/api.ts
@@ -9,7 +9,16 @@ export const api = createApi({
      */
     endpoints: () => ({}),
     invalidationBehavior: 'immediately',
-    tagTypes: ['All', 'PDiskData', 'PreviewData', 'StorageData', 'Tablet', 'UserData', 'VDiskData'],
+    tagTypes: [
+        'All',
+        'PDiskData',
+        'PreviewData',
+        'SchemaTree',
+        'StorageData',
+        'Tablet',
+        'UserData',
+        'VDiskData',
+    ],
 });
 
 export const _NEVER = Symbol();
diff --git a/src/store/reducers/overview/overview.ts b/src/store/reducers/overview/overview.ts
index 47091c9c2..a50202131 100644
--- a/src/store/reducers/overview/overview.ts
+++ b/src/store/reducers/overview/overview.ts
@@ -51,7 +51,7 @@ export const overviewApi = api.injectEndpoints({
                 }
             },
             keepUnusedDataFor: 0,
-            providesTags: ['All'],
+            providesTags: ['All', 'SchemaTree'],
         }),
     }),
 });
diff --git a/src/store/reducers/preview.ts b/src/store/reducers/preview.ts
index dc0cf4769..780fc21bb 100644
--- a/src/store/reducers/preview.ts
+++ b/src/store/reducers/preview.ts
@@ -29,7 +29,7 @@ export const previewApi = api.injectEndpoints({
                     return {error: error || new Error('Unauthorized')};
                 }
             },
-            providesTags: ['All', 'PreviewData'],
+            providesTags: ['PreviewData'],
         }),
     }),
     overrideExisting: 'throw',
diff --git a/src/store/reducers/schemaAcl/schemaAcl.ts b/src/store/reducers/schemaAcl/schemaAcl.ts
index 9df58a5bd..c8278dba9 100644
--- a/src/store/reducers/schemaAcl/schemaAcl.ts
+++ b/src/store/reducers/schemaAcl/schemaAcl.ts
@@ -18,7 +18,7 @@ export const schemaAclApi = api.injectEndpoints({
                     return {error};
                 }
             },
-            providesTags: ['All'],
+            providesTags: ['SchemaTree'],
         }),
     }),
     overrideExisting: 'throw',
diff --git a/src/store/reducers/viewSchema/viewSchema.ts b/src/store/reducers/viewSchema/viewSchema.ts
index 878c60b20..63f757455 100644
--- a/src/store/reducers/viewSchema/viewSchema.ts
+++ b/src/store/reducers/viewSchema/viewSchema.ts
@@ -37,7 +37,7 @@ export const viewSchemaApi = api.injectEndpoints({
                     return {error: error};
                 }
             },
-            providesTags: ['All'],
+            providesTags: ['All', 'SchemaTree'],
         }),
     }),
     overrideExisting: 'throw',