Deny pass null to CreateService::getTemplate() #313

Activity

1. vjik

   added this to the 3.0 milestone on Dec 20, 2025
2. vjik

   added

   type:enhancementEnhancementEnhancement

   on Dec 20, 2025
3. samdark commented on Dec 20, 2025

   

   samdark

   on Dec 20, 2025

   Member

   More actions

   The reason was to have a nicer exception "You must define a template to generate the migration." instead of generic type mismatch.

   public function getTemplate(?string $key): string
       {
           $key = (string) $key;
   
           if ($this->templates === null) {
               $this->setDefaultTemplates();
           }
   
           if (!isset($this->templates[$key])) {
               throw new InvalidConfigException('You must define a template to generate the migration.');
           }
   
           return $this->templates[$key];
       }
4. vjik commented on Dec 20, 2025

   

   vjik

   on Dec 20, 2025

   MemberAuthor

   More actions

   The reason was to have a nicer exception "You must define a template to generate the migration." instead of generic type mismatch.

   null is never passed to this method.

   👍React with 👍1Reacted by Alexander Makarov
5. samdark

   added

   good first issueSimple enough issue to start with.Simple enough issue to start with.

   status:ready for adoptionFeel free to implement this issue.Feel free to implement this issue.

   on Dec 20, 2025