Skip to content

Added PHPUnit tests as a GitHub action #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

simialbi
Copy link

@simialbi simialbi commented Oct 15, 2019

This action executes PHPUnit tests without travis dependency. It works with default GitHub actions:
https://github.com/simialbi/template/commit/ca01a608d262959eb3fcb5948b76dc9698b0cf2f/checks?check_suite_id=265348254

Q A
Is bugfix?
New feature? ✔️
Breaks BC? 〰️ (could replace travis)
Tests pass? ✔️
Fixed issues

@samdark
Copy link
Member

samdark commented Oct 15, 2019

Where can I see the output?

@simialbi
Copy link
Author

simialbi commented Oct 15, 2019

Click the link above or:
image

@samdark
Copy link
Member

samdark commented Oct 15, 2019

It doesn't show up here:

image

That's big loss in usability :(

@simialbi
Copy link
Author

Because I did not open a pull request in simialbi/template, I did for yiisoft/template which hasn't this action (yet). If it would have, it should show up in pull requests.

@samdark
Copy link
Member

samdark commented Oct 15, 2019

That's interesting.

@samdark
Copy link
Member

samdark commented Oct 15, 2019

18s via actions vs 54s via travis. Looks tempting.

@samdark
Copy link
Member

samdark commented Oct 15, 2019

@simialbi any guide on how to add action necessary?

@simialbi
Copy link
Author

No. This action should work everywhere without any changes.

@simialbi
Copy link
Author

I tested it on bootstrap 4 repository too which is a bit more complex (old php versions, different os's):
https://github.com/simialbi/yii2-bootstrap4/runs/229876551

@samdark
Copy link
Member

samdark commented Oct 16, 2019

In this case travis was faster so I wonder if it worth switching...

@simialbi
Copy link
Author

I would consider switching. Travis is an external service, GitHub action isn't...

@simialbi
Copy link
Author

And it could have consumed more time because I have limited concurrent actions to 3... (max-parallel: 3)

@simialbi
Copy link
Author

Yes it's like I supposed. As soon as I remove max-parallel the GitHub action is much faster: https://github.com/simialbi/yii2-bootstrap4/runs/265376015

@samdark
Copy link
Member

samdark commented Oct 18, 2019

Thanks for putting it all together. I'll apply it to one of the repositories to see how it goes.

@samdark
Copy link
Member

samdark commented Jun 8, 2020

By now it's applied to many repos. Thanks again @simialbi for making us very interested in Github actions.

@samdark samdark closed this Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants