Consider moving sizeToBytes from validator to formatter.

[Eseperio]

This method is often useful when working with systems that implement sizes with digits+text notation. Code is available as private method within FileValidator, while it could be integrated onto formatter.

yii2/framework/validators/FileValidator.php

Line 377 in 161526c

private function sizeToBytes($sizeStr)

[WinterSilence]

Same function ini_parse_quantity() will be added in PHP 8.2

[samdark]

That makes sense overall. Feel free to make a pull request.

[mspirkov]

I think this is a good idea. But in my opinion, it's better to move this method to BaseStringHelper. Here's the PR: #20550

[Eseperio]

Size to bytes is clearly a format change, so i do not see the link with a helper for strings.

[mspirkov]

This is an auxiliary function that does not depend on any external settings. It seems to me that the formatter contains primarily those methods that depend on any external settings.

[mspirkov]

I also believe that you should not use the global Yii class too often, as it can make testing more difficult.

[mspirkov]

@samdark @terabytesoftw @Eseperio
The pull request has been merged. Is there anything else we'd like to discuss?

[mspirkov]

I would like to make sure that everything is ok before adding this feature to yiisoft/strings (#20550 (comment))

[mspirkov]

I also added this feature to yiisoft/strings (yiisoft/strings@c877036)