Skip to content

Commit 7dc4d29

Browse files
committed
Imprve
1 parent 186bff4 commit 7dc4d29

File tree

1 file changed

+22
-12
lines changed

1 file changed

+22
-12
lines changed

src/App/Helper/MinMaxHelper.php

+22-12
Original file line numberDiff line numberDiff line change
@@ -81,23 +81,12 @@ private function appendCollectionDoc(CollectionDoc $doc, Constraint $constraint)
8181
} elseif ($constraint instanceof Assert\NotBlank && null === $doc->getMinItem()) {
8282
// Not blank so minimum 1 item
8383
$doc->setMinItem(1);
84-
} elseif ($constraint instanceof Assert\GreaterThan || $constraint instanceof Assert\GreaterThanOrEqual) {
85-
$doc->setMinItem(
86-
$constraint instanceof Assert\GreaterThanOrEqual
87-
? $constraint->value
88-
: $constraint->value + 1
89-
);
90-
} elseif ($constraint instanceof Assert\LessThan || $constraint instanceof Assert\LessThanOrEqual) {
91-
$doc->setMaxItem(
92-
$constraint instanceof Assert\LessThanOrEqual
93-
? $constraint->value
94-
: $constraint->value - 1
95-
);
9684
} /* Documentation does not mention array, counter to NotBlank constraint
9785
elseif ($constraint instanceof Assert\Blank && null === $doc->getMaxItem()) {
9886
// Blank so maximum 0 item
9987
$doc->setMaxItem(0);
10088
}*/
89+
$this->appendLessGreaterThanMinMaxItem($doc, $constraint);
10190
}
10291

10392
/**
@@ -123,4 +112,25 @@ private function appendNumberMinMax(NumberDoc $doc, Constraint $constraint) : vo
123112
$doc->setMin($constraint->value);
124113
}
125114
}
115+
116+
/**
117+
* @param CollectionDoc $doc
118+
* @param Constraint $constraint
119+
*/
120+
private function appendLessGreaterThanMinMaxItem(CollectionDoc $doc, Constraint $constraint): void
121+
{
122+
if ($constraint instanceof Assert\GreaterThan || $constraint instanceof Assert\GreaterThanOrEqual) {
123+
$doc->setMinItem(
124+
$constraint instanceof Assert\GreaterThanOrEqual
125+
? $constraint->value
126+
: $constraint->value + 1
127+
);
128+
} elseif ($constraint instanceof Assert\LessThan || $constraint instanceof Assert\LessThanOrEqual) {
129+
$doc->setMaxItem(
130+
$constraint instanceof Assert\LessThanOrEqual
131+
? $constraint->value
132+
: $constraint->value - 1
133+
);
134+
}
135+
}
126136
}

0 commit comments

Comments
 (0)