Underscore in heading title

[duglin]

I have a heading defined like this:

#### unknown_id

but goldmark seems to generate a header like this:

<h4 id="unknown-id">unknown_id</h4>

notice the "-" vs "_".

And then my use of the href is written like this in my markdown:

[unknown_id](#unknown_id)

which gets generated in html as:

<a href="#unknown_id">unknown_id</a>

So when I click on the "href" the browser can't find it since the "hr" ID has it as a dash.

I tried to find an extension/option to control this but didn't see one. Github keeps it all as underscores. Any ideas? thanks!

[duglin]

While I'd prefer if the anchor retained the underscore, I think all that really matters is that it is consistent and either retains it or changes it in both places. But changing just one side of the linking leads to a problem for users.

[duglin]

I changed my mind.... I think the "_" MUST to be retained because otherwise markdown files for github will break if people use "_" in their cross-references.

All that's needed is this change:

diff --git a/parser/parser.go b/parser/parser.go
index 78a6b26..92b5093 100644
--- a/parser/parser.go
+++ b/parser/parser.go
@@ -83,12 +83,12 @@ func (s *ids) Generate(value []byte, kind ast.NodeKind) []byte {
                if l != 1 {
                        continue
                }
-               if util.IsAlphaNumeric(v) {
+               if util.IsAlphaNumeric(v) || v == '_' {
                        if 'A' <= v && v <= 'Z' {
                                v += 'a' - 'A'
                        }
                        result = append(result, v)
-               } else if util.IsSpace(v) || v == '-' || v == '_' {
+               } else if util.IsSpace(v) || v == '-' {
                        result = append(result, '-')
                }
        }

I really don't want to fork the repo to get a working solution. Any chance of this being looked at soon?