Revert "Remove unused history event check (temporalio#3373)"

yux0 · yux0 · commit 6b7836501eed · 2022-09-16T11:22:17.000-07:00
This reverts commit 5e6b2d7.
diff --git a/service/history/workflow/context.go b/service/history/workflow/context.go
@@ -672,13 +672,16 @@ func (c *ContextImpl) SetWorkflowExecution(ctx context.Context, now time.Time) (
 		}
 	}()
 
-	resetWorkflowSnapshot, _, err := c.MutableState.CloseTransactionAsSnapshot(
+	resetWorkflowSnapshot, resetWorkflowEventsSeq, err := c.MutableState.CloseTransactionAsSnapshot(
 		now,
 		TransactionPolicyPassive,
 	)
 	if err != nil {
 		return err
 	}
+	if len(resetWorkflowEventsSeq) != 0 {
+		return serviceerror.NewInternal("SetWorkflowExecution encountered new events")
+	}
 
 	resetWorkflowSnapshot.ExecutionInfo.ExecutionStats = &persistencespb.ExecutionStats{
 		HistorySize: c.GetHistorySize(),

Original file line number	Diff line number	Diff line change
`@@ -672,13 +672,16 @@ func (c *ContextImpl) SetWorkflowExecution(ctx context.Context, now time.Time) (`
`672`	`672`	`}`
`673`	`673`	`}()`
`674`	`674`
`675`		`- resetWorkflowSnapshot, _, err := c.MutableState.CloseTransactionAsSnapshot(`
	`675`	`+ resetWorkflowSnapshot, resetWorkflowEventsSeq, err := c.MutableState.CloseTransactionAsSnapshot(`
`676`	`676`	`now,`
`677`	`677`	`TransactionPolicyPassive,`
`678`	`678`	`)`
`679`	`679`	`if err != nil {`
`680`	`680`	`return err`
`681`	`681`	`}`
	`682`	`+ if len(resetWorkflowEventsSeq) != 0 {`
	`683`	`+ return serviceerror.NewInternal("SetWorkflowExecution encountered new events")`
	`684`	`+ }`
`682`	`685`
`683`	`686`	`resetWorkflowSnapshot.ExecutionInfo.ExecutionStats = &persistencespb.ExecutionStats{`
`684`	`687`	`HistorySize: c.GetHistorySize(),`