Skip to content

Commit 1817398

Browse files
goldelicotmlind
authored andcommitted
ARM: dts; gta04: SPI panel chip select is active low
With the arrival of commit 2fee958 ("spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors") it was clarified what the proper state for cs-gpios should be, even if the flag is ignored. The driver code is doing the right thing since 766c6b6 ("spi: fix client driver breakages when using GPIO descriptors") The chip-select of the td028ttec1 panel is active-low, so we must omit spi-cs-high; attribute (already removed by separate patch) and should now use GPIO_ACTIVE_LOW for the client device description to be fully consistent. Fixes: 766c6b6 ("spi: fix client driver breakages when using GPIO descriptors") CC: [email protected] Signed-off-by: H. Nikolaus Schaller <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 7078a5b commit 1817398

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/arm/boot/dts/omap3-gta04.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
gpio-sck = <&gpio1 12 GPIO_ACTIVE_HIGH>;
115115
gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
116116
gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
117-
cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
117+
cs-gpios = <&gpio1 19 GPIO_ACTIVE_LOW>;
118118
num-chipselects = <1>;
119119

120120
/* lcd panel */

0 commit comments

Comments
 (0)