Skip to content

Commit ecbf472

Browse files
Muchun Songtorvalds
authored andcommitted
mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active
The page_huge_active() can be called from scan_movable_pages() which do not hold a reference count to the HugeTLB page. So when we call page_huge_active() from scan_movable_pages(), the HugeTLB page can be freed parallel. Then we will trigger a BUG_ON which is in the page_huge_active() when CONFIG_DEBUG_VM is enabled. Just remove the VM_BUG_ON_PAGE. Link: https://lkml.kernel.org/r/[email protected] Fixes: 7e1f049 ("mm: hugetlb: cleanup using paeg_huge_active()") Signed-off-by: Muchun Song <[email protected]> Reviewed-by: Mike Kravetz <[email protected]> Acked-by: Michal Hocko <[email protected]> Reviewed-by: Oscar Salvador <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: Yang Shi <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 0eb2df2 commit ecbf472

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

mm/hugetlb.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1361,8 +1361,7 @@ struct hstate *size_to_hstate(unsigned long size)
13611361
*/
13621362
bool page_huge_active(struct page *page)
13631363
{
1364-
VM_BUG_ON_PAGE(!PageHuge(page), page);
1365-
return PageHead(page) && PagePrivate(&page[1]);
1364+
return PageHeadHuge(page) && PagePrivate(&page[1]);
13661365
}
13671366

13681367
/* never called for tail page */

0 commit comments

Comments
 (0)