https access fix (#196)

* https access fix

* update https reader option

* update test for https check

Author: ayushnag

virtualizarr/tests/test_xarray.py

@@ -376,7 +376,7 @@ def test_read_from_url(self, filetype, url):
             with pytest.raises(NotImplementedError):
                 vds = open_virtual_dataset(url, reader_options={}, indexes={})
         else:
-            vds = open_virtual_dataset(url, reader_options={}, indexes={})
+            vds = open_virtual_dataset(url, indexes={})
             assert isinstance(vds, xr.Dataset)
 
 

virtualizarr/xarray.py

@@ -10,6 +10,7 @@
 
 import ujson  # type: ignore
 import xarray as xr
+from upath import UPath
 from xarray import register_dataset_accessor
 from xarray.backends import BackendArray
 from xarray.coding.times import CFDatetimeCoder
@@ -125,9 +126,14 @@ def open_virtual_dataset(
         )
     else:
         if reader_options is None:
-            reader_options = {
-                "storage_options": {"key": "", "secret": "", "anon": True}
-            }
+            universal_filepath = UPath(filepath)
+            protocol = universal_filepath.protocol
+            if protocol == "s3":
+                reader_options = {
+                    "storage_options": {"key": "", "secret": "", "anon": True}
+                }
+            else:
+                reader_options = {}
 
         # this is the only place we actually always need to use kerchunk directly
         # TODO avoid even reading byte ranges for variables that will be dropped later anyway?