temp disabled validate_and_normalize_path_to_uri due to issue in zarr-python v3: zarr-developers/zarr-python#2554

Author: norlandrhagen

virtualizarr/manifests/manifest.py

@@ -49,7 +49,8 @@ def with_validation(
 
         # note: we can't just use `__init__` or a dataclass' `__post_init__` because we need `fs_root` to be an optional kwarg
 
-        path = validate_and_normalize_path_to_uri(path, fs_root=fs_root)
+        # commenting out for now: https://github.com/zarr-developers/zarr-python/issues/2554
+        # path = validate_and_normalize_path_to_uri(path, fs_root=fs_root)
         validate_byte_range(offset=offset, length=length)
         return ChunkEntry(path=path, offset=offset, length=length)
 

virtualizarr/readers/zarr.py

@@ -9,14 +9,13 @@
 from xarray import Dataset, Index, Variable
 
 from virtualizarr.manifests import ChunkManifest, ManifestArray
-from virtualizarr.manifests.manifest import validate_and_normalize_path_to_uri
 from virtualizarr.readers.common import (
     VirtualBackend,
     construct_virtual_dataset,
     open_loadable_vars_and_indexes,
     separate_coords,
 )
-from virtualizarr.utils import _FsspecFSFromFilepath, check_for_collisions
+from virtualizarr.utils import check_for_collisions
 from virtualizarr.zarr import ZArray
 
 if TYPE_CHECKING:
@@ -154,13 +153,15 @@ def virtual_dataset_from_zarr_group(
 ) -> Dataset:
     import zarr
 
-    vfpath = validate_and_normalize_path_to_uri(filepath, fs_root=Path.cwd().as_uri())
+    # vfpath = validate_and_normalize_path_to_uri(filepath, fs_root=Path.cwd().as_uri())
     # This currently fails: *** TypeError: Filesystem needs to support async operations.
     # https://github.com/zarr-developers/zarr-python/issues/2554
 
-    fss = _FsspecFSFromFilepath(filepath=vfpath, reader_options=reader_options)
+    # import ipdb; ipdb.set_trace()
 
-    zg = zarr.open_group(fss.get_mapper(), mode="r")
+    zg = zarr.open_group(
+        filepath, storage_options=reader_options.get("storage_options"), mode="r"
+    )
 
     zarr_arrays = [val for val in zg.keys()]
 

virtualizarr/tests/test_integration.py

@@ -107,11 +107,14 @@ def test_numpy_arrays_to_inlined_kerchunk_refs(
     ],
     indirect=True,
 )
-def test_zarrV2_roundtrip(zarr_store):
+def test_zarr_roundtrip(zarr_store):
     ds = open_virtual_dataset(
         zarr_store,
         indexes={},
     )
+    import ipdb
+
+    ipdb.set_trace()
     ds_refs = ds.virtualize.to_kerchunk(format="dict")
 
     roundtrip = dataset_from_kerchunk_refs(ds_refs)