-
Notifications
You must be signed in to change notification settings - Fork 40
Switch tests to use HDF reader instead of kerchunk-based HDF5 reader #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Most of the integration tests in https://github.com/zarr-developers/VirtualiZarr/blob/main/virtualizarr/tests/test_integration.py are parameterized to use both Sean's HDF5 reader and the kerchunk reader. Do we want to just remove the kerchunk reader from those tests or figure out a pattern for skipping the kerchunk reader run when kerchunk is unavailable? |
Yeah I realised that yesterday too.
See #392 (comment) - the objective is to be able to run the tests without kerchunk even being installed. I think that means that for now we just remove the kerchunk reader from those tests. |
Right! But there could be tests that do run if kerchunk is installed and are just skipped otherwise. Anyways I am going to take this one on now. I think it makes sense to do this one before #376 |
We want to be able to pin
I agree, thanks for taking this on. |
It felt weird to delete tests that exercise functionality. So see what you think of the approach. |
I guess it's fine for us to keep tests that will never be run by the CI (until kerchunk reaches v3 compatibility and can be re-instated). |
Zarr v3 was officially released today, but we still can't just explicitly depend on it because kerchunk doesn't work with zarr v3. There is a compatibility branch of kerchunk, which is sufficient to get kerchunk's readers working again, but development of that branch has stalled due to errors that arise in kerchunk's
MultiZarrToZarr
code.We can't just depend directly on this compatibility branch because that's janky AF.
If we try to change our dependency to zarr v3 these things will break:
Breaking the kerchunk-based readers wouldn't be that bad - we have @sharkinsspatial 's HDF reader as an alternative for opening HDF/netCDF4 files, and the other two are much less complex/commonly used.
Breaking our integration tests isn't really acceptable, so what we should try is swapping all those tests to use Sean's HDF reader instead of the kerchunk-based HDF5 reader. If that works then we can move forward, and the only downside is that we would have to raise a warning in the HDF5, netCDF3, and FITS readers that you need to install the weird compatibility branch of kerchunk. That's better than the current situation, where you need the weird compatibility branch if you want to use zarr v3 (and therefore icechunk!) at all.
cc @norlandrhagen @mpiannucci
The text was updated successfully, but these errors were encountered: