raise ValueError if create_dataset's dimension_separator is inconsistent

Author: grlee77

zarr/creation.py

@@ -124,6 +124,12 @@ def create(shape, chunks=True, dtype=None, compressor='default',
     # optional array metadata
     if dimension_separator is None:
         dimension_separator = getattr(store, "_dimension_separator", None)
+    else:
+        if getattr(store, "_dimension_separator", None) != dimension_separator:
+            raise ValueError(
+                f"Specified dimension_separtor: {dimension_separator}"
+                f"conflicts with store's separator: "
+                f"{store._dimension_separator}")
     dimension_separator = normalize_dimension_separator(dimension_separator)
 
     # initialize array metadata

zarr/tests/test_hierarchy.py

@@ -1003,6 +1003,18 @@ def create_store():
         store = FSStore(path, key_separator='/', auto_mkdir=True)
         return store, None
 
+    def test_inconsistent_dimension_separator(self):
+        data = np.arange(1000).reshape(10, 10, 10)
+        name = 'raw'
+
+        store, _ = self.create_store()
+        f = open_group(store, mode='w')
+
+        # cannot specify dimension_separator that conflicts with the store
+        with pytest.raises(ValueError):
+            f.create_dataset(name, data=data, chunks=(5, 5, 5),
+                             compressor=None, dimension_separator='.')
+
 
 class TestGroupWithZipStore(TestGroup):