lint

d-v-b · d-v-b · commit 90666ea5eb41 · 2025-09-25T16:14:42.000+02:00
diff --git a/tests/test_codecs/test_adler32.py b/tests/test_codecs/test_adler32.py
@@ -9,8 +9,8 @@ class TestAdler32Codec(BaseTestCodec):
     test_cls = _numcodecs.Adler32
     valid_json_v2 = (
         {"id": "adler32"},
-        {"id": "adler32", "location": "start"},  # type: ignore[typeddict-unknown-key]
-        {"id": "adler32", "location": "end"},  # type: ignore[typeddict-unknown-key]
+        {"id": "adler32", "location": "start"},
+        {"id": "adler32", "location": "end"},
     )
     valid_json_v3 = (
         {"name": "adler32", "configuration": {}},
diff --git a/tests/test_codecs/test_astype.py b/tests/test_codecs/test_astype.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestAsTypeCodec(BaseTestCodec):
     test_cls = _numcodecs.AsType
-    valid_json_v2 = ({"id": "astype", "encode_dtype": "<f4", "decode_dtype": "<f4"},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "astype", "encode_dtype": "<f4", "decode_dtype": "<f4"},)
     valid_json_v3 = (
         {
             "name": "astype",
diff --git a/tests/test_codecs/test_bitround.py b/tests/test_codecs/test_bitround.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestBitRoundCodec(BaseTestCodec):
     test_cls = _numcodecs.BitRound
-    valid_json_v2 = ({"id": "bitround", "keepbits": 8},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "bitround", "keepbits": 8},)
     valid_json_v3 = (
         {
             "name": "bitround",
diff --git a/tests/test_codecs/test_blosc.py b/tests/test_codecs/test_blosc.py
@@ -24,7 +24,7 @@
 class TestBloscCodec(BaseTestCodec):
     test_cls = BloscCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "blosc",
             "cname": "lz4",
             "clevel": 5,
diff --git a/tests/test_codecs/test_blosc_numcodecs.py b/tests/test_codecs/test_blosc_numcodecs.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestBloscNumcodecsCodec(BaseTestCodec):
     test_cls = _numcodecs.Blosc
-    valid_json_v2 = ({"id": "blosc", "clevel": 5, "shuffle": 1, "blocksize": 0, "cname": "lz4"},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "blosc", "clevel": 5, "shuffle": 1, "blocksize": 0, "cname": "lz4"},)
     valid_json_v3 = (
         {
             "name": "blosc",
diff --git a/tests/test_codecs/test_bytes.py b/tests/test_codecs/test_bytes.py
@@ -18,7 +18,7 @@
 class TestBytesCodec(BaseTestCodec):
     test_cls = BytesCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "bytes",
             "endian": "little",
         },
diff --git a/tests/test_codecs/test_bz2.py b/tests/test_codecs/test_bz2.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestBZ2Codec(BaseTestCodec):
     test_cls = _numcodecs.BZ2
-    valid_json_v2 = ({"id": "bz2", "level": 1},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "bz2", "level": 1},)
     valid_json_v3 = (
         {
             "name": "bz2",
diff --git a/tests/test_codecs/test_codecs.py b/tests/test_codecs/test_codecs.py
@@ -48,7 +48,7 @@ async def get(self) -> NDArrayLikeOrScalar:
         return await self.array.getitem(self.selection)
 
     async def set(self, value: np.ndarray[Any, Any]) -> None:
-        return await self.array.setitem(self.selection, value)
+        return await self.array.setitem(self.selection, value)  # type: ignore[no-any-return]
 
 
 def order_from_dim(order: MemoryOrder, ndim: int) -> tuple[int, ...]:
diff --git a/tests/test_codecs/test_delta.py b/tests/test_codecs/test_delta.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestDeltaCodec(BaseTestCodec):
     test_cls = _numcodecs.Delta
-    valid_json_v2 = ({"id": "delta", "dtype": "|u1", "astype": "|u1"},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "delta", "dtype": "|u1", "astype": "|u1"},)
     valid_json_v3 = (
         {
             "name": "delta",
diff --git a/tests/test_codecs/test_fixedscaleoffset.py b/tests/test_codecs/test_fixedscaleoffset.py
@@ -8,7 +8,7 @@
 class TestFixedScaleOffsetCodec(BaseTestCodec):
     test_cls = _numcodecs.FixedScaleOffset
     valid_json_v2 = (
-        {"id": "fixedscaleoffset", "scale": 1.0, "offset": 0.0, "astype": "|u1", "dtype": "|u1"},  # type: ignore[typeddict-unknown-key]
+        {"id": "fixedscaleoffset", "scale": 1.0, "offset": 0.0, "astype": "|u1", "dtype": "|u1"},
     )
     valid_json_v3 = (
         {
diff --git a/tests/test_codecs/test_gzip.py b/tests/test_codecs/test_gzip.py
@@ -19,7 +19,7 @@
 class TestGZipCodec(BaseTestCodec):
     test_cls = GzipCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "gzip",
             "level": 1,
         },
@@ -35,7 +35,7 @@ class TestGZipCodec(BaseTestCodec):
 
 
 class TestNumcodecsGZipCodec(TestGZipCodec):
-    test_cls = znumcodecs.GZip  # type: ignore[assignment]
+    test_cls = znumcodecs.GZip
 
 
 @pytest.mark.parametrize(
diff --git a/tests/test_codecs/test_gzip_numcodecs.py b/tests/test_codecs/test_gzip_numcodecs.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestGZipNumcodecsCodec(BaseTestCodec):
     test_cls = _numcodecs.GZip
-    valid_json_v2 = ({"id": "gzip", "level": 1},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "gzip", "level": 1},)
     valid_json_v3 = (
         {
             "name": "gzip",
diff --git a/tests/test_codecs/test_jenkinslookup3.py b/tests/test_codecs/test_jenkinslookup3.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestJenkinsLookup3Codec(BaseTestCodec):
     test_cls = _numcodecs.JenkinsLookup3
-    valid_json_v2 = ({"id": "jenkins_lookup3", "initval": 0, "prefix": None},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "jenkins_lookup3", "initval": 0, "prefix": None},)
     valid_json_v3 = (
         {
             "name": "jenkins_lookup3",
diff --git a/tests/test_codecs/test_lz4.py b/tests/test_codecs/test_lz4.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestLZ4Codec(BaseTestCodec):
     test_cls = _numcodecs.LZ4
-    valid_json_v2 = ({"id": "lz4", "acceleration": 1},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "lz4", "acceleration": 1},)
     valid_json_v3 = (
         {
             "name": "lz4",
diff --git a/tests/test_codecs/test_lzma.py b/tests/test_codecs/test_lzma.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestLZMACodec(BaseTestCodec):
     test_cls = _numcodecs.LZMA
-    valid_json_v2 = ({"id": "lzma", "filters": None, "preset": None, "format": 1, "check": -1},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "lzma", "filters": None, "preset": None, "format": 1, "check": -1},)
     valid_json_v3 = (
         {
             "name": "lzma",
diff --git a/tests/test_codecs/test_numcodecs.py b/tests/test_codecs/test_numcodecs.py
@@ -60,7 +60,7 @@ def codec_conf() -> Iterator[Any]:
 
 
 def test_get_numcodec() -> None:
-    assert get_numcodec({"id": "gzip", "level": 2}) == GZip(level=2)  # type: ignore[typeddict-unknown-key]
+    assert get_numcodec({"id": "gzip", "level": 2}) == GZip(level=2)
 
 
 def test_is_numcodec() -> None:
@@ -94,7 +94,7 @@ def test_is_numcodec_cls() -> None:
     [codec for codec in ALL_CODECS if codec.codec_name.split(".")[-1] not in CODECS_WITH_SPECS],
 )
 def test_get_codec_class(codec_cls: type[_numcodecs._NumcodecsCodec]) -> None:
-    assert get_codec_class(codec_cls.codec_name) == codec_cls  # type: ignore[comparison-overlap]
+    assert get_codec_class(codec_cls.codec_name) == codec_cls
 
 
 @pytest.mark.parametrize("codec_class", ALL_CODECS)
diff --git a/tests/test_codecs/test_pcodec.py b/tests/test_codecs/test_pcodec.py
@@ -15,7 +15,7 @@
 class TestPCodec(BaseTestCodec):
     test_cls = PCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "pcodec",
             "level": 8,
             "mode_spec": "auto",
@@ -88,5 +88,5 @@ def test_generic_bytes_codec(codec_class: type[_NumcodecsArrayBytesCodec]) -> No
             serializer=codec_class(),
         )
 
-    a[:, :] = data.copy()  # type: ignore[index]
-    np.testing.assert_array_equal(data, a[:, :])  # type: ignore[index]
+    a[:, :] = data.copy()
+    np.testing.assert_array_equal(data, a[:, :])
diff --git a/tests/test_codecs/test_quantize.py b/tests/test_codecs/test_quantize.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestQuantizeCodec(BaseTestCodec):
     test_cls = _numcodecs.Quantize
-    valid_json_v2 = ({"id": "quantize", "digits": 3, "astype": "<f4", "dtype": "<f4"},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "quantize", "digits": 3, "astype": "<f4", "dtype": "<f4"},)
     valid_json_v3 = (
         {
             "name": "quantize",
diff --git a/tests/test_codecs/test_sharding.py b/tests/test_codecs/test_sharding.py
@@ -35,7 +35,7 @@
 class TestShardingCodec(BaseTestCodec):
     test_cls = ShardingCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "sharding_indexed",
             "chunk_shape": (32, 32),
             "codecs": ({"id": "bytes", "endian": "little"},),
diff --git a/tests/test_codecs/test_shuffle_numcodecs.py b/tests/test_codecs/test_shuffle_numcodecs.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestShuffleNumcodecsCodec(BaseTestCodec):
     test_cls = _numcodecs.Shuffle
-    valid_json_v2 = ({"id": "shuffle", "elementsize": 4},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "shuffle", "elementsize": 4},)
     valid_json_v3 = (
         {
             "name": "shuffle",
diff --git a/tests/test_codecs/test_transpose.py b/tests/test_codecs/test_transpose.py
@@ -20,7 +20,7 @@
 class TestTransposeCodec(BaseTestCodec):
     test_cls = TransposeCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "transpose",
             "order": (2, 1, 0),
         },
@@ -127,5 +127,5 @@ def test_transpose_invalid(
                 dtype=data.dtype,
                 fill_value=0,
                 chunk_key_encoding={"name": "v2", "separator": "."},
-                filters=[TransposeCodec(order=order)],  # type: ignore[arg-type]
+                filters=[TransposeCodec(order=order)],
             )
diff --git a/tests/test_codecs/test_zfpy.py b/tests/test_codecs/test_zfpy.py
@@ -9,7 +9,7 @@
 class TestZFPYCodec(BaseTestCodec):
     test_cls = _numcodecs.ZFPY
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "zfpy",
             "mode": 4,
             "compression_kwargs": {"tolerance": -1},
diff --git a/tests/test_codecs/test_zlib_numcodecs.py b/tests/test_codecs/test_zlib_numcodecs.py
@@ -7,7 +7,7 @@
 @pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")
 class TestZlibNumcodecsCodec(BaseTestCodec):
     test_cls = _numcodecs.Zlib
-    valid_json_v2 = ({"id": "zlib", "level": 1},)  # type: ignore[typeddict-unknown-key]
+    valid_json_v2 = ({"id": "zlib", "level": 1},)
     valid_json_v3 = (
         {
             "name": "zlib",
diff --git a/tests/test_codecs/test_zstd.py b/tests/test_codecs/test_zstd.py
@@ -16,7 +16,7 @@
 class TestZstdCodec(BaseTestCodec):
     test_cls = ZstdCodec
     valid_json_v2 = (
-        {  # type: ignore[typeddict-unknown-key]
+        {
             "id": "zstd",
             "level": 0,
         },

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")`
`8`	`8`	`class TestAsTypeCodec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.AsType`
`10`		`- valid_json_v2 = ({"id": "astype", "encode_dtype": "<f4", "decode_dtype": "<f4"},) # type: ignore[typeddict-unknown-key]`
	`10`	`+ valid_json_v2 = ({"id": "astype", "encode_dtype": "<f4", "decode_dtype": "<f4"},)`
`11`	`11`	`valid_json_v3 = (`
`12`	`12`	`{`
`13`	`13`	`"name": "astype",`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")`
`8`	`8`	`class TestBitRoundCodec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.BitRound`
`10`		`- valid_json_v2 = ({"id": "bitround", "keepbits": 8},) # type: ignore[typeddict-unknown-key]`
	`10`	`+ valid_json_v2 = ({"id": "bitround", "keepbits": 8},)`
`11`	`11`	`valid_json_v3 = (`
`12`	`12`	`{`
`13`	`13`	`"name": "bitround",`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")`
`8`	`8`	`class TestBloscNumcodecsCodec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.Blosc`
`10`		`- valid_json_v2 = ({"id": "blosc", "clevel": 5, "shuffle": 1, "blocksize": 0, "cname": "lz4"},) # type: ignore[typeddict-unknown-key]`
	`10`	`+ valid_json_v2 = ({"id": "blosc", "clevel": 5, "shuffle": 1, "blocksize": 0, "cname": "lz4"},)`
`11`	`11`	`valid_json_v3 = (`
`12`	`12`	`{`
`13`	`13`	`"name": "blosc",`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")`
`8`	`8`	`class TestBZ2Codec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.BZ2`
`10`		`- valid_json_v2 = ({"id": "bz2", "level": 1},) # type: ignore[typeddict-unknown-key]`
	`10`	`+ valid_json_v2 = ({"id": "bz2", "level": 1},)`
`11`	`11`	`valid_json_v3 = (`
`12`	`12`	`{`
`13`	`13`	`"name": "bz2",`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`@pytest.mark.filterwarnings("ignore::zarr.errors.ZarrUserWarning")`
`8`	`8`	`class TestDeltaCodec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.Delta`
`10`		`- valid_json_v2 = ({"id": "delta", "dtype": "\|u1", "astype": "\|u1"},) # type: ignore[typeddict-unknown-key]`
	`10`	`+ valid_json_v2 = ({"id": "delta", "dtype": "\|u1", "astype": "\|u1"},)`
`11`	`11`	`valid_json_v3 = (`
`12`	`12`	`{`
`13`	`13`	`"name": "delta",`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`class TestFixedScaleOffsetCodec(BaseTestCodec):`
`9`	`9`	`test_cls = _numcodecs.FixedScaleOffset`
`10`	`10`	`valid_json_v2 = (`
`11`		`- {"id": "fixedscaleoffset", "scale": 1.0, "offset": 0.0, "astype": "\|u1", "dtype": "\|u1"}, # type: ignore[typeddict-unknown-key]`
	`11`	`+ {"id": "fixedscaleoffset", "scale": 1.0, "offset": 0.0, "astype": "\|u1", "dtype": "\|u1"},`
`12`	`12`	`)`
`13`	`13`	`valid_json_v3 = (`
`14`	`14`	`{`