Set file permissions in DirectoryStorage according to umask

Fixes #320

Author: eddienko

zarr/storage.py

@@ -73,6 +73,12 @@ def _path_to_prefix(path):
         prefix = ''
     return prefix
 
+def _NamedTemporaryFileUmask(*args, **kargs):
+    fdesc = tempfile.NamedTemporaryFile(*args, **kargs)
+    umask = os.umask(0)
+    os.umask(umask)
+    os.chmod(fdesc.name, 0o666 & ~umask)
+    return fdesc
 
 def contains_array(store, path=None):
     """Return True if the store contains an array at the given logical path."""
@@ -752,9 +758,9 @@ def __setitem__(self, key, value):
         # write to temporary file
         temp_path = None
         try:
-            with tempfile.NamedTemporaryFile(mode='wb', delete=False, dir=dir_path,
-                                             prefix=file_name + '.',
-                                             suffix='.partial') as f:
+            with _NamedTemporaryFileUmask(mode='wb', delete=False, dir=dir_path,
+                                          prefix=file_name + '.',
+                                          suffix='.partial') as f:
                 temp_path = f.name
                 f.write(value)
 

zarr/tests/test_storage.py

@@ -721,6 +721,14 @@ def test_filesystem_path(self):
         store['foo'] = b'bar'
         assert os.path.isdir(path)
 
+        # check correct permissions
+        stat = os.stat(path)
+        mode = stat.st_mode & 0o666
+        umask = os.umask(0)
+        os.umask(umask)
+        assert mode == (0o666 & ~umask)
+
+
         # test behaviour with file path
         with tempfile.NamedTemporaryFile() as f:
             with pytest.raises(ValueError):