Skip to content

Commit bebfc6c

Browse files
committed
Fix duplicate dim_sep kwargs
1 parent c0f69b1 commit bebfc6c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

zarr/tests/test_storage.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1062,8 +1062,10 @@ def test_s3_complex(self):
10621062
@pytest.mark.skipif(have_fsspec is False, reason="needs fsspec")
10631063
class TestFSStoreWithDefaultDimensionSeparator(StoreTests):
10641064

1065-
def create_store(self, normalize_keys=False,
1066-
dimension_separator=".", **kwargs):
1065+
def create_store(self, normalize_keys=False, **kwargs):
1066+
1067+
kwargs.pop("dimension_separator", None)
1068+
dimension_separator = "."
10671069

10681070
# Since the user is passing key_separator, that will take priority.
10691071
skip_if_nested_chunks(**kwargs)
@@ -1173,6 +1175,7 @@ class TestNestedDirectoryStoreWithDefaultValue(TestDirectoryStore):
11731175
def create_store(self, normalize_keys=False, **kwargs):
11741176
path = tempfile.mkdtemp()
11751177
atexit.register(atexit_rmtree, path)
1178+
kwargs.pop("dimension_separator", None)
11761179
store = NestedDirectoryStore(
11771180
path, normalize_keys=normalize_keys,
11781181
dimension_separator="/", **kwargs)

0 commit comments

Comments
 (0)