Skip to content

[v3] Array constructor API compatibility #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhamman opened this issue Jun 6, 2024 · 1 comment · Fixed by #2186
Closed

[v3] Array constructor API compatibility #1953

jhamman opened this issue Jun 6, 2024 · 1 comment · Fixed by #2186
Milestone

Comments

@jhamman
Copy link
Member

jhamman commented Jun 6, 2024

In addition to the top-level API compatibility layer, we are also seeing that some applications are interacting with the Array class constructor directly. For example, see this from Dask.

z = zarr.Array(url, read_only=True, path=component, **kwargs)

But our current constructor doesn't support this.

@dataclass(frozen=True)
class Array:
_async_array: AsyncArray

To be honest, I've been assuming no one was using Array.__init__ but that seems to have been a mistake.

Thanks @will-moore for reporting this (#1884 (comment)).

cc @jrbourbeau

@jhamman
Copy link
Member Author

jhamman commented Sep 14, 2024

dask/dask#11387 will help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant