Skip to content

Make azure-storage-blob an optional test requirement #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham opened this issue Mar 22, 2019 · 3 comments
Closed

Make azure-storage-blob an optional test requirement #419

jakirkham opened this issue Mar 22, 2019 · 3 comments
Milestone

Comments

@jakirkham
Copy link
Member

Currently azure-storage-blob is required for testing. Meaning that if it is not installed the tests cannot be run. It would be nice if azure-storage-blob was an optional test requirement. This way we could simply skip the tests that require azure-storage-blob and run the rest of the tests. For more details about the issue, please see this build log.

@jakirkham
Copy link
Member Author

Another reason this is a good idea is testing azure-storage-blob requires Azurite. While this is fine to use in CI or perhaps for a developer working on the Azure storage back end, it is not an easy ask in many other situations (e.g. packaging). So relaxing this requirement will help ensure the basic tests can still be run even when this requirement is not met.

@rabernat
Copy link
Contributor

I agree with making the azure libs an optional test requirement. As long as we have these test run in travis somewhere, that's enough.

On a practical note, I'm really hoping to install zarr 2.3 via conda forge. It sounds like that won't be happening. Is the idea to cut 2.3.1 asap it get around this conda forge test issue?

@jakirkham
Copy link
Member Author

Thanks for the review @rabernat. Yep the tests are still running on both CIs. Agree we should continue to do so.

Yes the idea is to do a quick hot-fix with just this change. Should have time to do it Monday if this is agreeable. Once we tag the release am planning on getting it in PyPI and conda-forge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants