You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently azure-storage-blob is required for testing. Meaning that if it is not installed the tests cannot be run. It would be nice if azure-storage-blob was an optional test requirement. This way we could simply skip the tests that require azure-storage-blob and run the rest of the tests. For more details about the issue, please see this build log.
The text was updated successfully, but these errors were encountered:
Another reason this is a good idea is testing azure-storage-blob requires Azurite. While this is fine to use in CI or perhaps for a developer working on the Azure storage back end, it is not an easy ask in many other situations (e.g. packaging). So relaxing this requirement will help ensure the basic tests can still be run even when this requirement is not met.
I agree with making the azure libs an optional test requirement. As long as we have these test run in travis somewhere, that's enough.
On a practical note, I'm really hoping to install zarr 2.3 via conda forge. It sounds like that won't be happening. Is the idea to cut 2.3.1 asap it get around this conda forge test issue?
Thanks for the review @rabernat. Yep the tests are still running on both CIs. Agree we should continue to do so.
Yes the idea is to do a quick hot-fix with just this change. Should have time to do it Monday if this is agreeable. Once we tag the release am planning on getting it in PyPI and conda-forge.
Currently
azure-storage-blob
is required for testing. Meaning that if it is not installed the tests cannot be run. It would be nice ifazure-storage-blob
was an optional test requirement. This way we could simply skip the tests that requireazure-storage-blob
and run the rest of the tests. For more details about the issue, please see this build log.The text was updated successfully, but these errors were encountered: