From 2bd18ed39bd191f0ce1eed42e80c1509ea1e6220 Mon Sep 17 00:00:00 2001 From: Joseph Hamman Date: Mon, 20 Dec 2021 14:52:18 -0700 Subject: [PATCH] fix consolidate_metadata with FSStore --- zarr/convenience.py | 2 +- zarr/tests/test_storage.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/zarr/convenience.py b/zarr/convenience.py index 20afb496b7..4d07968579 100644 --- a/zarr/convenience.py +++ b/zarr/convenience.py @@ -1117,7 +1117,7 @@ def consolidate_metadata(store: StoreLike, metadata_key=".zmetadata"): open_consolidated """ - store = normalize_store_arg(store) + store = normalize_store_arg(store, clobber=True) def is_zarr_key(key): return (key.endswith('.zarray') or key.endswith('.zgroup') or diff --git a/zarr/tests/test_storage.py b/zarr/tests/test_storage.py index da1b76e9c7..5a9fce1f8d 100644 --- a/zarr/tests/test_storage.py +++ b/zarr/tests/test_storage.py @@ -19,6 +19,7 @@ import zarr from zarr.codecs import BZ2, AsType, Blosc, Zlib +from zarr.convenience import consolidate_metadata from zarr.errors import MetadataError from zarr.hierarchy import group from zarr.meta import ZARR_FORMAT, decode_array_metadata @@ -1009,6 +1010,10 @@ def test_create(self): assert "data" in os.listdir(path1) assert ".zgroup" in os.listdir(path1) + # consolidated metadata (GH#915) + consolidate_metadata("file://" + path1) + assert ".zmetadata" in os.listdir(path1) + g = zarr.open_group("simplecache::file://" + path1, mode='r', storage_options={"cache_storage": path2, "same_names": True})