recovery shell: stop double printing errors on first launch

Author: zdykstra

zfsbootmenu/lib/kmsg-log-lib.sh

@@ -104,6 +104,7 @@ print_kmsg_logs() {
   # dmesg from dmesg-util can helpfully do --since, but only if it's also allowed to print the time out
   # so always print the time, optionally set --since, and filter the timestamp after
   if output="$( dmesg -f user --color=never -l "${levels}" ${since:+--since ${since}} 2>/dev/null )" ; then
+    # shellcheck disable=SC2001
     echo "${output}" | sed 's/^\[.*\]\ //'
   else
     # Both util-linux and Busybox dmesg support the -r flag. However, the log level that is

zfsbootmenu/lib/zfsbootmenu-core.sh

@@ -1943,7 +1943,8 @@ emergency_shell() {
 
   if [ -f "${BASE}/have_errors" ]; then
     print_kmsg_logs "err"
-    echo ""
+    echo
+    rm "${BASE}/have_errors"
   fi
 
   command -v efibootmgr >/dev/null 2>&1 && mount_efivarfs "rw" 

zfsbootmenu/libexec/recovery-error-printer

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-PROMPT_TS_FILE="${BASE}/.errors_since"
+PROMPT_TS_FILE="${BASE}/errors_since"
 
 [ -f "${PROMPT_TS_FILE}" ] && read -r prompt_ts < "${PROMPT_TS_FILE}"
 
@@ -11,7 +11,7 @@ if [ -f "${BASE}/have_errors" ]; then
   echo
   print_kmsg_logs "err" ${prompt_ts:+${prompt_ts}}
   echo
-  rm "/zfsbootmenu/have_errors" 
+  rm "${BASE}/have_errors"
 fi
 
 printf '%(%Y-%m-%dT%H:%M:%S)T' > "${PROMPT_TS_FILE}"