Skip to content

The ability to search the documentation has disappeared #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DianaNites opened this issue Mar 20, 2025 · 3 comments
Closed

The ability to search the documentation has disappeared #262

DianaNites opened this issue Mar 20, 2025 · 3 comments

Comments

@DianaNites
Copy link

mdbook documentation normally has the ability to search for text within it, and the zellij documentation did have this ability at least as recently as Dec 16th, 2024 https://web.archive.org/web/20241216052032/https://zellij.dev/documentation/introduction.html, because the search icon can be seen. That corresponds to the previous release of v0.41.2, from Nov 19th, 2024.

This has since disappeared, making the documentation much harder to navigate and reference.

I can find no obvious code or configuration change that caused this, book.toml does not disable search, and search is enabled by default in mdBook

maybe of note, searcher.js exists in the old-documentation folder, but not the new documentation, but did exist in the version_41 branch

It appears to have been removed in #258 at commit "theme specification" 78564eb#diff-1977f86fe551fbda907d3b27d28d50c69d21a542dc0271465a71fb24e90aab3a

@imsnif
Copy link
Member

imsnif commented Mar 20, 2025

Hey, thank you for pointing this out! This was likely due to rust-lang/mdBook#2586 (I was building with mdbook 0.4.45). I upgraded to 0.4.47, rebuilt the static assets and the search is back now.

Also, thanks for the detailed bisect and troubleshooting, it helped me find the problem quicker.

@DianaNites
Copy link
Author

Thanks for the quick fix, search is back

This seems to have undone the fix for the broken theme specs image, however f332ec0#diff-2d32c33b352af5d44227cef4bc96705de8fe9108614da592eb5f05426de7096f

https://zellij.dev/documentation/themes.html#theme-definition-specification

@imsnif
Copy link
Member

imsnif commented Mar 21, 2025

You are right - just issued a fix and it's back now. Thanks once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants