Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Commit ea81011

Browse files
committed
Replace assertContainsOnly calls in SharedEventManagerTest
The behavior of `assertContainsOnly()` changed in PHPUnit 7, and now expects the first argument is a string type. Previously, we were passing an instance to find in the array. Now we pull the single discovered listener off and test using `assertSame()`.
1 parent 025d242 commit ea81011

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/SharedEventManagerTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,10 @@ public function testClearListenersRemovesAllExplicitListenersForGivenIdentifierA
196196
$listeners = $this->getListeners($this->manager, ['IDENTIFIER'], 'EVENT');
197197
$this->assertInternalType('array', $listeners, 'Unexpected return value from getListeners() for event EVENT');
198198
$this->assertCount(1, $listeners);
199-
$this->assertContainsOnly($wildcard, $listeners, null, sprintf(
199+
$listener = array_shift($listeners);
200+
$this->assertSame($wildcard, $listener, sprintf(
200201
'Expected only wildcard listener on event EVENT after clearListener operation; received: %s',
201-
var_export($listeners, 1)
202+
var_export($listener, 1)
202203
));
203204

204205
$listeners = $this->getListeners($this->manager, ['IDENTIFIER'], 'ALTERNATE');
@@ -208,7 +209,8 @@ public function testClearListenersRemovesAllExplicitListenersForGivenIdentifierA
208209
'Unexpected return value from getListeners() for event ALTERNATE'
209210
);
210211
$this->assertCount(1, $listeners);
211-
$this->assertContainsOnly($alternate, $listeners, null, 'Unexpected listener list for event ALTERNATE');
212+
$listener = array_shift($listeners);
213+
$this->assertSame($alternate, $listener, 'Unexpected listener list for event ALTERNATE');
212214
}
213215

214216
public function testClearListenersDoesNotRemoveWildcardListenersWhenEventIsProvided()

0 commit comments

Comments
 (0)