Merge branch 'hotfix/aliases' into develop

Forward port #69

Author: weierophinney

CHANGELOG.md

@@ -20,7 +20,7 @@ All notable changes to this project will be documented in this file, in reverse
 
 - Nothing.
 
-## 2.8.3 - TBD
+## 2.8.3 - 2016-05-03
 
 ### Added
 
@@ -37,7 +37,9 @@ All notable changes to this project will be documented in this file, in reverse
 
 ### Fixed
 
-- Nothing.
+- [#69](https://github.com/zendframework/zend-form/pull/69) fixes aliases in the
+  `FormElementManager` polyfill for zend-servicemanager v2 to ensure they are
+  canonicalized correctly.
 
 ## 2.8.2 - 2016-05-01
 

src/FormElementManager/FormElementManagerV2Polyfill.php

@@ -54,9 +54,7 @@ class FormElementManagerV2Polyfill extends AbstractPluginManager
         'image'          => Element\Image::class,
         'month'          => Element\Month::class,
         'monthselect'    => Element\MonthSelect::class,
-        'MonthSelect'    => Element\MonthSelect::class,
-        'multiCheckbox'  => Element\MultiCheckbox::class,
-        'multiCheckBox'  => Element\MultiCheckbox::class,
+        'multicheckbox'  => Element\MultiCheckbox::class,
         'number'         => Element\Number::class,
         'password'       => Element\Password::class,
         'radio'          => Element\Radio::class,

test/FormElementManagerTest.php

@@ -221,4 +221,21 @@ public function testAddingInvokableCreatesAliasAndMapsClassToElementFactory()
             $this->assertEquals(ElementFactory::class, $factories['zendtestformtestassetelementwithfilter']);
         }
     }
+
+    public function testAllAliasesShouldBeCanonicalized()
+    {
+        if (method_exists($this->manager, 'configure')) {
+            $this->markTestSkipped('Check canonicalized makes sense only on v2');
+        }
+
+        $r = new ReflectionProperty($this->manager, 'aliases');
+        $r->setAccessible(true);
+        $aliases = $r->getValue($this->manager);
+
+        foreach ($aliases as $name => $alias) {
+            $this->manager->get($name . ' ');
+            $this->manager->get(strtoupper($name));
+            $this->manager->get($name);
+        }
+    }
 }