Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Commit 386289d

Browse files
committed
Merge branch 'hotfix/initializers' into develop
Forward port #65
2 parents e08ccdf + 553bfc8 commit 386289d

File tree

9 files changed

+2895
-71
lines changed

9 files changed

+2895
-71
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ nbproject
99
tmp/
1010

1111
clover.xml
12-
composer.lock
1312
coveralls-upload.json
1413
phpunit.xml
1514
vendor

.travis.yml

Lines changed: 36 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,11 @@ branches:
1010
cache:
1111
directories:
1212
- $HOME/.composer/cache
13+
- vendor
1314

1415
env:
1516
global:
17+
- COMPOSER_ARGS="--no-interaction --ignore-platform-reqs"
1618
- TESTS_ZEND_FORM_ANNOTATION_SUPPORT=true
1719
- TESTS_ZEND_FORM_RECAPTCHA_SUPPORT=true
1820

@@ -21,32 +23,41 @@ matrix:
2123
include:
2224
- php: 5.5
2325
env:
24-
- EXECUTE_CS_CHECK=true
26+
- DEPS=lowest
2527
- php: 5.5
2628
env:
27-
- EVENT_MANAGER_VERSION="^2.6.2"
28-
- HYDRATOR_VERSION="^1.1"
29-
- SERVICE_MANAGER_VERSION="^2.7.5"
29+
- DEPS=locked
30+
- CS_CHECK=true
31+
- php: 5.5
32+
env:
33+
- DEPS=latest
3034
- php: 5.6
3135
env:
32-
- EXECUTE_TEST_COVERALLS=true
36+
- DEPS=lowest
3337
- php: 5.6
3438
env:
35-
- EVENT_MANAGER_VERSION="^2.6.2"
36-
- HYDRATOR_VERSION="^1.1"
37-
- SERVICE_MANAGER_VERSION="^2.7.5"
39+
- DEPS=locked
40+
- php: 5.6
41+
env:
42+
- DEPS=latest
43+
- php: 7
44+
env:
45+
- DEPS=lowest
3846
- php: 7
47+
env:
48+
- DEPS=locked
3949
- php: 7
4050
env:
41-
- EVENT_MANAGER_VERSION="^2.6.2"
42-
- HYDRATOR_VERSION="^1.1"
43-
- SERVICE_MANAGER_VERSION="^2.7.5"
51+
- DEPS=latest
4452
- php: hhvm
53+
env:
54+
- DEPS=lowest
55+
- php: hhvm
56+
env:
57+
- DEPS=locked
4558
- php: hhvm
4659
env:
47-
- EVENT_MANAGER_VERSION="^2.6.2"
48-
- HYDRATOR_VERSION="^1.1"
49-
- SERVICE_MANAGER_VERSION="^2.7.5"
60+
- DEPS=latest
5061
allow_failures:
5162
- php: hhvm
5263

@@ -55,24 +66,20 @@ notifications:
5566
email: false
5667

5768
before_install:
58-
- if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
59-
- composer self-update
60-
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then composer require --dev --no-update satooshi/php-coveralls ; fi
61-
- if [[ $EVENT_MANAGER_VERSION != '' ]]; then composer require --dev --no-update "zendframework/zend-eventmanager:$EVENT_MANAGER_VERSION" ; fi
62-
- if [[ $EVENT_MANAGER_VERSION == '' ]]; then composer require --dev --no-update "zendframework/zend-eventmanager:^3.0" ; fi
63-
- if [[ $HYDRATOR_VERSION != '' ]]; then composer require --no-update "zendframework/zend-stdlib:^2.7" ; fi
64-
- if [[ $HYDRATOR_VERSION != '' ]]; then composer require --no-update "zendframework/zend-hydrator:$HYDRATOR_VERSION" ; fi
65-
- if [[ $SERVICE_MANAGER_VERSION != '' ]]; then composer require --dev --no-update "zendframework/zend-servicemanager:$SERVICE_MANAGER_VERSION" ; fi
66-
- if [[ $SERVICE_MANAGER_VERSION = '' ]]; then composer require --dev --no-update "zendframework/zend-servicemanager:^3.0.3" ; fi
69+
- if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi
70+
- travis_retry composer self-update
6771

6872
install:
69-
- travis_retry composer install --no-interaction --ignore-platform-reqs
70-
- composer info -i
73+
- if [[ $DEPS == 'latest' ]]; then travis_retry composer update $COMPOSER_ARGS ; fi
74+
- if [[ $DEPS == 'lowest' ]]; then travis_retry composer update --prefer-lowest --prefer-stable $COMPOSER_ARGS ; fi
75+
- if [[ $TEST_COVERAGE == 'true' ]]; then travis_retry composer require --dev $COMPOSER_ARGS satooshi/php-coveralls:^1.0 ; fi
76+
- travis_retry composer install $COMPOSER_ARGS
77+
- composer show --installed
7178

7279
script:
73-
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then ./vendor/bin/phpunit --coverage-clover clover.xml ; fi
74-
- if [[ $EXECUTE_TEST_COVERALLS != 'true' ]]; then ./vendor/bin/phpunit ; fi
75-
- if [[ $EXECUTE_CS_CHECK == 'true' ]]; then ./vendor/bin/php-cs-fixer fix -v --diff --dry-run ; fi
80+
- if [[ $TEST_COVERAGE == 'true' ]]; then composer test-coverage ; fi
81+
- if [[ $TEST_COVERAGE != 'true' ]]; then composer test ; fi
82+
- if [[ $CS_CHECK == 'true' ]]; then composer cs-check ; fi
7683

7784
after_script:
78-
- if [[ $EXECUTE_TEST_COVERALLS == 'true' ]]; then ./vendor/bin/coveralls ; fi
85+
- if [[ $TEST_COVERAGE == 'true' ]]; then composer upload-coverage ; fi

CHANGELOG.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ All notable changes to this project will be documented in this file, in reverse
3737

3838
### Fixed
3939

40-
- Nothing.
40+
- [#65](https://github.com/zendframework/zend-form/pull/65) fixes instantiation
41+
of `Zend\Form\FormElementManager` to ensure that the default initializers,
42+
`injectFactory()` and `callElementInit()` are registered as the first and last
43+
initializers, respectively, during construction, restoring the pre-2.7
44+
behavior.
4145

4246
## 2.8.1 - 2016-04-18
4347

composer.json

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"zendframework/zend-view": "^2.6.2",
3535
"zendframework/zendservice-recaptcha": "*",
3636
"fabpot/php-cs-fixer": "1.7.*",
37-
"phpunit/PHPUnit": "~4.0"
37+
"phpunit/phpunit": "^4.8"
3838
},
3939
"suggest": {
4040
"zendframework/zend-captcha": "Zend\\Captcha component",
@@ -63,5 +63,16 @@
6363
"psr-4": {
6464
"ZendTest\\Form\\": "test/"
6565
}
66+
},
67+
"scripts": {
68+
"check": [
69+
"@cs-check",
70+
"@test"
71+
],
72+
"upload-coverage": "coveralls -v",
73+
"cs-check": "php-cs-fixer --version && php-cs-fixer fix -v --diff --dry-run",
74+
"cs-fix": "php-cs-fixer fix -v",
75+
"test": "phpunit",
76+
"test-coverage": "phpunit --coverage-clover clover.xml"
6677
}
6778
}

0 commit comments

Comments
 (0)