Failing test for #66

Author: zluiten

test/FactoryTest.php

@@ -783,4 +783,26 @@ public function testOptionsArePassedAsCreationOptionsToFactories()
         $this->assertInstanceOf(DateTime::class, $created);
         $this->assertSame('2016-02-19', $created->format('Y-m-d'));
     }
+
+    public function testCanCreateWithConstructionLogicInOptions()
+    {
+        $formManager = $this->factory->getFormElementManager();
+        $formManager->setFactory(TestAsset\FieldsetWithDependency::class, TestAsset\FieldsetWithDependencyFactory::class);
+
+        $collection = $this->factory->create([
+            'type' => Form\Element\Collection::class,
+            'name' => 'my_fieldset_collection',
+            'options' => [
+                'target_element' => [
+                    'type' => TestAsset\FieldsetWithDependency::class,
+                ],
+            ],
+        ]);
+
+        $this->assertInstanceOf(Form\Element\Collection::class, $collection);
+
+        $targetElement = $collection->getTargetElement();
+        $this->assertInstanceOf(TestAsset\FieldsetWithDependency::class, $targetElement);
+        $this->assertInstanceOf(TestAsset\InputFilter::class, $targetElement->getDependency());
+    }
 }

test/TestAsset/FieldsetWithDependency.php

@@ -0,0 +1,46 @@
+<?php
+/**
+ * @link      http://github.com/zendframework/zend-form for the canonical source repository
+ * @copyright Copyright (c) 2005-2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace ZendTest\Form\TestAsset;
+
+use Zend\Form\Element;
+use Zend\Form\Fieldset;
+
+class FieldsetWithDependency extends Fieldset
+{
+    /**
+     * @var InputFilter
+     */
+    private $dependency;
+
+    public function __construct($name = null, $options = [])
+    {
+        parent::__construct('fielset_with_dependency', $options);
+    }
+    
+    public function init()
+    {
+        // should not fail
+        $this->dependency->getValues();
+    }
+
+    /**
+     * @return InputFilter
+     */
+    public function getDependency()
+    {
+        return $this->dependency;
+    }
+
+    /**
+     * @param InputFilter $dependency
+     */
+    public function setDependency($dependency)
+    {
+        $this->dependency = $dependency;
+    }
+}

test/TestAsset/FieldsetWithDependencyFactory.php

@@ -0,0 +1,45 @@
+<?php
+/**
+ * @link      http://github.com/zendframework/zend-form for the canonical source repository
+ * @copyright Copyright (c) 2005-2016 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace ZendTest\Form\TestAsset;
+
+use Interop\Container\ContainerInterface;
+use Zend\ServiceManager\FactoryInterface;
+use Zend\ServiceManager\ServiceLocatorInterface;
+
+class FieldsetWithDependencyFactory implements FactoryInterface
+{
+    private $creationOptions = [];
+
+    public function __invoke(ContainerInterface $container, $name, array $options = null)
+    {
+        $options = $options ?: [];
+
+        $name = null;
+        if (isset($options['name'])) {
+            $name = $options['name'];
+            unset($options['name']);
+        }
+
+        $form = new FieldsetWithDependency($name, $options);
+        $dependency = new InputFilter();
+        
+        $form->setDependency($dependency);
+        
+        return $form;
+    }
+
+    public function createService(ServiceLocatorInterface $container)
+    {
+        return $this($container, CustomCreatedForm::class, $this->creationOptions);
+    }
+
+    public function setCreationOptions(array $options)
+    {
+        $this->creationOptions = $options;
+    }
+}