Merge pull request #20 from terpfear/patch-1

Stop FormRow from translating the label twice

Author: weierophinney

src/View/Helper/FormRow.php

@@ -199,7 +199,7 @@ public function render(ElementInterface $element, $labelPosition = null)
                 ) {
                     $labelOpen = '';
                     $labelClose = '';
-                    $label = $labelHelper($element);
+                    $label = $labelHelper->openTag($element) . $label . $labelHelper->closeTag();
                 } else {
                     $labelOpen  = $labelHelper->openTag($labelAttributes);
                     $labelClose = $labelHelper->closeTag();

test/View/Helper/FormRowTest.php

@@ -248,6 +248,45 @@ public function testTranslatorMethods()
         $this->assertFalse($this->helper->isTranslatorEnabled());
     }
 
+    public function testLabelWillBeTranslatedOnceWithoutId()
+    {
+        $element = new Element('foo');
+        $element->setLabel('The value for foo:');
+
+        $mockTranslator = $this->getMock('Zend\I18n\Translator\Translator');
+        $mockTranslator->expects($this->exactly(1))
+            ->method('translate')
+            ->will($this->returnValue('translated content'));
+
+        $this->helper->setTranslator($mockTranslator);
+        $this->assertTrue($this->helper->hasTranslator());
+
+        $markup = $this->helper->__invoke($element);
+        $this->assertContains('>translated content<', $markup);
+        $this->assertContains('<label', $markup);
+        $this->assertContains('</label>', $markup);
+    }
+
+    public function testLabelWillBeTranslatedOnceWithId()
+    {
+        $element = new Element('foo');
+        $element->setLabel('The value for foo:');
+        $element->setAttribute('id', 'foo');
+
+        $mockTranslator = $this->getMock('Zend\I18n\Translator\Translator');
+        $mockTranslator->expects($this->exactly(1))
+            ->method('translate')
+            ->will($this->returnValue('translated content'));
+
+        $this->helper->setTranslator($mockTranslator);
+        $this->assertTrue($this->helper->hasTranslator());
+
+        $markup = $this->helper->__invoke($element);
+        $this->assertContains('>translated content<', $markup);
+        $this->assertContains('<label', $markup);
+        $this->assertContains('</label>', $markup);
+    }
+
     public function testSetLabelPositionInputNullRaisesException()
     {
         $this->setExpectedException('Zend\Form\Exception\InvalidArgumentException');