This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Zend\Mime\Message setter methods should return $this #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okdana
changed the title
Zend\Mime\Message setter methods should return $this
weierophinney
added a commit
that referenced
this pull request
Nov 28, 2017
Zend\Mime\Message setter methods should return $this
weierophinney
added a commit
that referenced
this pull request
Nov 28, 2017
weierophinney
added a commit
that referenced
this pull request
Nov 28, 2017
|
Thanks, @okdana |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the setter methods in
Zend\Mime\PartandZend\Mail\Messagereturn$this, allowing you to chain calls to those methods.Zend\Mime\Messagedoesn't work this way, for seemingly no particular reason.The PR simply adds
return $thisto those few setter functions. There should be no API breakage or other BC issues AFAIK. Tests pass (there weren't any that relied on the existing behaviour, of course).