Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Fix header type inconsistency #36

Closed
wants to merge 1 commit into from
Closed

Fix header type inconsistency #36

wants to merge 1 commit into from

Conversation

sunspikes
Copy link
Contributor

@sunspikes sunspikes commented Dec 18, 2018

There is a small inconsistency the way Decode:: splitMessage() behaves, the headers variable referenced in splitMessage is supposed to of type Headers always, but when splitMessage is called with an empty content headers will become an empty array. This breaks client libraries for example: https://github.com/zendframework/zend-mail/blob/master/src/Message.php#L566

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
    • Detail the original, incorrect behavior.
    • Detail the new, expected behavior.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

@michalbundyra michalbundyra added this to the 2.7.2 milestone Oct 16, 2019
michalbundyra added a commit that referenced this pull request Oct 16, 2019
@michalbundyra
Copy link
Member

Thanks, @sunspikes!

michalbundyra added a commit that referenced this pull request Oct 16, 2019
michalbundyra added a commit that referenced this pull request Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants