Skip to content

Commit 3bc75de

Browse files
committed
feat: remove change of format
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
1 parent d2cf989 commit 3bc75de

2 files changed

Lines changed: 16 additions & 12 deletions

File tree

src/index/src/inverted_index/format/writer.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,5 @@ pub trait InvertedIndexWriter {
3737
S: Stream<Item = Result<(Bytes, BitVec)>> + Send + Unpin;
3838

3939
/// Finalizes the index writing process, ensuring all data is written.
40-
/// `total_row_count` and `segment_row_count` is used to fill in the metadata.
41-
async fn finish(&mut self, total_row_count: u64, segment_row_count: u64) -> Result<()>;
40+
async fn finish(&mut self) -> Result<()>;
4241
}

src/index/src/inverted_index/format/writer/blob.rs

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,7 @@ impl<W: AsyncWrite + Send + Unpin> InvertedIndexWriter for InvertedIndexBlobWrit
5858
Ok(())
5959
}
6060

61-
async fn finish(&mut self, total_row_count: u64, segment_row_count: u64) -> Result<()> {
62-
self.metas.segment_row_count = segment_row_count;
63-
self.metas.total_row_count = total_row_count;
64-
61+
async fn finish(&mut self) -> Result<()> {
6562
let metas_bytes = self.metas.encode_to_vec();
6663
self.blob_writer
6764
.write_all(&metas_bytes)
@@ -81,11 +78,19 @@ impl<W: AsyncWrite + Send + Unpin> InvertedIndexWriter for InvertedIndexBlobWrit
8178
}
8279

8380
impl<W: AsyncWrite + Send + Unpin> InvertedIndexBlobWriter<W> {
84-
pub fn new(blob_writer: W) -> InvertedIndexBlobWriter<W> {
81+
pub fn new(
82+
blob_writer: W,
83+
total_row_count: u64,
84+
segment_row_count: u64,
85+
) -> InvertedIndexBlobWriter<W> {
8586
InvertedIndexBlobWriter {
8687
blob_writer,
8788
written_size: 0,
88-
metas: InvertedIndexMetas::default(),
89+
metas: InvertedIndexMetas {
90+
total_row_count,
91+
segment_row_count,
92+
..Default::default()
93+
},
8994
}
9095
}
9196
}
@@ -104,8 +109,8 @@ mod tests {
104109
#[tokio::test]
105110
async fn test_inverted_index_blob_writer_write_empty() {
106111
let mut blob = Vec::new();
107-
let mut writer = InvertedIndexBlobWriter::new(&mut blob);
108-
writer.finish(8, 1).await.unwrap();
112+
let mut writer = InvertedIndexBlobWriter::new(&mut blob, 8, 1);
113+
writer.finish().await.unwrap();
109114

110115
let cursor = Cursor::new(blob);
111116
let mut reader = InvertedIndexBlobReader::new(cursor);
@@ -118,7 +123,7 @@ mod tests {
118123
#[tokio::test]
119124
async fn test_inverted_index_blob_writer_write_basic() {
120125
let mut blob = Vec::new();
121-
let mut writer = InvertedIndexBlobWriter::new(&mut blob);
126+
let mut writer = InvertedIndexBlobWriter::new(&mut blob, 8, 1);
122127
writer
123128
.add_index(
124129
"tag0".to_string(),
@@ -143,7 +148,7 @@ mod tests {
143148
)
144149
.await
145150
.unwrap();
146-
writer.finish(8, 1).await.unwrap();
151+
writer.finish().await.unwrap();
147152

148153
let cursor = Cursor::new(blob);
149154
let mut reader = InvertedIndexBlobReader::new(cursor);

0 commit comments

Comments
 (0)