Skip to content

wasi: syscalls relying on fd_readdir right fail with wasmtime >= v0.23 #8742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kubkon opened this issue May 11, 2021 · 1 comment · Fixed by #9031
Closed

wasi: syscalls relying on fd_readdir right fail with wasmtime >= v0.23 #8742

kubkon opened this issue May 11, 2021 · 1 comment · Fixed by #9031
Labels
bug Observed behavior contradicts documented or intended behavior os-wasi standard library This issue involves writing Zig code for the standard library.
Milestone
0.9.0

Comments

@kubkon
Copy link
Member

kubkon commented May 11, 2021

See bytecodealliance/wasmtime#2891 for context. In summary, any function such as std.fs.Dir.deleteTree which requires a call to readdir syscall will fail when run against wasmtime at least v0.23 since the way the rights are cascaded has fundamentally changed.

This issue is a blocker at bumping supported wasmtime version from v0.22.2, and its resolution will require scanning through relevant wasmtime's implementation of rights management and working out how to handle rights distribution within Zig's libstd.
@kubkon kubkon added bug Observed behavior contradicts documented or intended behavior standard library This issue involves writing Zig code for the standard library. os-wasi labels May 11, 2021
@kubkon kubkon added this to the 0.9.0 milestone May 11, 2021
@kubkon
Copy link
Member Author

kubkon commented May 11, 2021

cc @ifreund @Luukdegram

@kubkon kubkon mentioned this issue May 11, 2021
Merged
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 May 19, 2021
@kubkon kubkon mentioned this issue Jun 7, 2021
Merged
@andrewrk andrewrk modified the milestones: 0.10.0, 0.9.0 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Observed behavior contradicts documented or intended behavior os-wasi standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

wasi: always grant fd_readdir right ziglang/zig
2 participants
@andrewrk @kubkon