Skip to content

Commit abb2346

Browse files
committed
fix(errors): Turn off require-atomic-updates, it is very buggy
1 parent 828ce5a commit abb2346

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

packages/eslint-config-zillow-base/rules/errors.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@ module.exports = {
153153

154154
// Disallow assignments that can lead to race conditions due to usage of await or yield
155155
// https://eslint.org/docs/rules/require-atomic-updates
156-
'require-atomic-updates': 'error',
156+
// NOTE: not enabled because it is very buggy
157+
'require-atomic-updates': 'off',
157158

158159
// disallow comparisons with the value NaN
159160
'use-isnan': 'error',

packages/eslint-plugin-zillow/test/__snapshots__/eslint-plugin-zillow.test.js.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1668,7 +1668,7 @@ Object {
16681668
"error",
16691669
],
16701670
"require-atomic-updates": Array [
1671-
"error",
1671+
"off",
16721672
],
16731673
"require-await": Array [
16741674
"off",

0 commit comments

Comments
 (0)