chore: drop serde_yaml rename (#2015)

* chore(deps): drop serde_yaml rename, use yaml_serde directly

The workspace currently aliases yaml_serde 0.10 as serde_yaml via
Cargo package renaming. This was a useful porting convenience when
migrating away from the deprecated serde_yaml 0.9, but now that the
migration is complete it actively confuses readers: the manifest says
serde_yaml, the source says serde_yaml::Value, but the actual crate
is yaml_serde.

This bit downstream consumers of yamlpatch 1.25.0, whose public
Op::Replace(serde_yaml::Value) signature is in fact
Op::Replace(yaml_serde::Value) due to this same rename. Downstream
code that constructed a real serde_yaml::Value saw an unreadable
"expected yaml_serde::Value, found serde_yaml::Value" error.

Switch the workspace dependency from serde_yaml = { package =
"yaml_serde", version = "0.10" } to yaml_serde = "0.10" and rename
all ~249 source references from serde_yaml:: to yaml_serde::. This
brings the manifest, source code, and compiler diagnostics into
agreement.

No behavior change. cargo check, cargo fmt --check, and the
non-network-dependent test suites pass on the workspace.

* chore: add .git-blame-ignore-revs for mechanical rename

Lists the serde_yaml -> yaml_serde rename commit so `git blame` and
GitHub's blame view skip it and surface the prior author of each
touched line instead. Run once locally to opt in:

  git config blame.ignoreRevsFile .git-blame-ignore-revs

GitHub honors the file automatically.

Author: mostafa

.git-blame-ignore-revs

@@ -0,0 +1,2 @@
+# chore(deps): drop serde_yaml rename, use yaml_serde directly
+d706f97cf294e09f4a3d22c2dc8b32a54a2fe508

Cargo.toml

@@ -66,7 +66,7 @@ serde = { version = "1.0.228", features = ["derive"] }
 serde-sarif = "0.8.0"
 serde_json = "1.0.149"
 serde_json_path = "0.7.2"
-serde_yaml = { package = "yaml_serde", version = "0.10" }
+yaml_serde = "0.10"
 tar = "0.4.45"
 terminal-link = "0.1.0"
 thiserror = "2.0.18"

crates/github-actions-models/Cargo.toml

@@ -19,7 +19,7 @@ workspace = true
 indexmap.workspace = true
 self_cell.workspace = true
 serde.workspace = true
-serde_yaml.workspace = true
+yaml_serde.workspace = true
 tracing.workspace = true
 
 [dev-dependencies]

crates/github-actions-models/src/action.rs

@@ -213,10 +213,10 @@ mod tests {
 
     #[test]
     fn test_docker_action_uses_deserialization() {
-        let uses: DockerActionUses = serde_yaml::from_str("Dockerfile").unwrap();
+        let uses: DockerActionUses = yaml_serde::from_str("Dockerfile").unwrap();
         assert!(matches!(uses, DockerActionUses::Dockerfile));
 
-        let uses: DockerActionUses = serde_yaml::from_str("ubuntu:latest").unwrap();
+        let uses: DockerActionUses = yaml_serde::from_str("ubuntu:latest").unwrap();
         assert!(matches!(uses, DockerActionUses::Image(_)));
     }
 }

crates/github-actions-models/src/common.rs

@@ -585,13 +585,13 @@ mod tests {
     #[test]
     fn test_permissions() {
         assert_eq!(
-            serde_yaml::from_str::<Permissions>("read-all").unwrap(),
+            yaml_serde::from_str::<Permissions>("read-all").unwrap(),
             Permissions::Base(BasePermission::ReadAll)
         );
 
         let perm = "security-events: write";
         assert_eq!(
-            serde_yaml::from_str::<Permissions>(perm).unwrap(),
+            yaml_serde::from_str::<Permissions>(perm).unwrap(),
             Permissions::Explicit(IndexMap::from([(
                 "security-events".into(),
                 Permission::Write
@@ -603,7 +603,7 @@ mod tests {
     fn test_env_empty_value() {
         let env = "foo:";
         assert_eq!(
-            serde_yaml::from_str::<Env>(env).unwrap()["foo"],
+            yaml_serde::from_str::<Env>(env).unwrap()["foo"],
             EnvValue::String("".into())
         );
     }
@@ -999,7 +999,7 @@ mod tests {
         struct Dummy(#[serde(deserialize_with = "reusable_step_uses")] Uses);
 
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "octo-org/this-repo/.github/workflows/workflow-1.yml@172239021f7ba04fe7327647b213799853a9eb89"
             )
             .map(|d| d.0)
@@ -1023,7 +1023,7 @@ mod tests {
         );
 
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "octo-org/this-repo/.github/workflows/workflow-1.yml@notahash"
             ).map(|d| d.0).unwrap(),
             @r#"
@@ -1045,7 +1045,7 @@ mod tests {
         );
 
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "octo-org/this-repo/.github/workflows/workflow-1.yml@abcd"
             ).map(|d| d.0).unwrap(),
             @r#"
@@ -1068,31 +1068,31 @@ mod tests {
 
         // Invalid: remote reusable workflow without ref
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "octo-org/this-repo/.github/workflows/workflow-1.yml"
             ).map(|d| d.0).unwrap_err(),
             @r#"Error("malformed `uses` ref: missing `@<ref>` in octo-org/this-repo/.github/workflows/workflow-1.yml")"#
         );
 
         // Invalid: local reusable workflow with ref
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "./.github/workflows/workflow-1.yml@172239021f7ba04fe7327647b213799853a9eb89"
             ).map(|d| d.0).unwrap_err(),
             @r#"Error("local reusable workflow reference can't specify `@<ref>`")"#
         );
 
         // Invalid: no ref at all
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 ".github/workflows/workflow-1.yml"
             ).map(|d| d.0).unwrap_err(),
             @r#"Error("malformed `uses` ref: missing `@<ref>` in .github/workflows/workflow-1.yml")"#
         );
 
         // Invalid: missing user/repo
         insta::assert_debug_snapshot!(
-            serde_yaml::from_str::<Dummy>(
+            yaml_serde::from_str::<Dummy>(
                 "workflow-1.yml@172239021f7ba04fe7327647b213799853a9eb89"
             ).map(|d| d.0).unwrap_err(),
             @r#"Error("malformed `uses` ref: owner/repo slug is too short: workflow-1.yml@172239021f7ba04fe7327647b213799853a9eb89")"#

crates/github-actions-models/src/common/expr.rs

@@ -104,7 +104,7 @@ mod tests {
 
         for case in cases {
             let case = format!("\"{case}\"");
-            assert!(serde_yaml::from_str::<ExplicitExpr>(&case).is_err());
+            assert!(yaml_serde::from_str::<ExplicitExpr>(&case).is_err());
         }
     }
 
@@ -119,7 +119,7 @@ mod tests {
             ("${{    foo     }}", "foo"),
         ] {
             let case = format!("\"{case}\"");
-            let expr: ExplicitExpr = serde_yaml::from_str(&case).unwrap();
+            let expr: ExplicitExpr = yaml_serde::from_str(&case).unwrap();
             assert_eq!(expr.as_bare(), *expected);
         }
     }
@@ -128,20 +128,20 @@ mod tests {
     fn test_loe() {
         let lit = "\"normal string\"";
         assert_eq!(
-            serde_yaml::from_str::<LoE<String>>(lit).unwrap(),
+            yaml_serde::from_str::<LoE<String>>(lit).unwrap(),
             LoE::Literal("normal string".to_string())
         );
 
         let expr = "\"${{ expr }}\"";
         assert!(matches!(
-            serde_yaml::from_str::<LoE<String>>(expr).unwrap(),
+            yaml_serde::from_str::<LoE<String>>(expr).unwrap(),
             LoE::Expr(_)
         ));
 
         // Invalid expr deserializes as string.
         let invalid = "\"${{ invalid \"";
         assert_eq!(
-            serde_yaml::from_str::<LoE<String>>(invalid).unwrap(),
+            yaml_serde::from_str::<LoE<String>>(invalid).unwrap(),
             LoE::Literal("${{ invalid ".to_string())
         );
     }

crates/github-actions-models/src/workflow/event.rs

@@ -358,7 +358,7 @@ pull_request:
 workflow_dispatch:
 issue_comment:";
 
-        let events = serde_yaml::from_str::<super::Events>(events).unwrap();
+        let events = yaml_serde::from_str::<super::Events>(events).unwrap();
         assert_eq!(events.count(), 4);
     }
 }

crates/github-actions-models/src/workflow/job.rs

@@ -2,7 +2,7 @@
 
 use indexmap::IndexMap;
 use serde::Deserialize;
-use serde_yaml::Value;
+use yaml_serde::Value;
 
 use crate::common::expr::{BoE, LoE};
 use crate::common::{DockerUses, Env, If, Permissions, Uses, custom_error};
@@ -218,12 +218,12 @@ mod tests {
     #[test]
     fn test_secrets() {
         assert_eq!(
-            serde_yaml::from_str::<Secrets>("inherit").unwrap(),
+            yaml_serde::from_str::<Secrets>("inherit").unwrap(),
             Secrets::Inherit
         );
 
         let secrets = "foo-secret: bar";
-        let Secrets::Env(secrets) = serde_yaml::from_str::<Secrets>(secrets).unwrap() else {
+        let Secrets::Env(secrets) = yaml_serde::from_str::<Secrets>(secrets).unwrap() else {
             panic!("unexpected secrets variant");
         };
         assert_eq!(secrets["foo-secret"], EnvValue::String("bar".into()));
@@ -235,7 +235,7 @@ mod tests {
         let Strategy {
             matrix: Some(LoE::Expr(expr)),
             ..
-        } = serde_yaml::from_str::<Strategy>(strategy).unwrap()
+        } = yaml_serde::from_str::<Strategy>(strategy).unwrap()
         else {
             panic!("unexpected matrix variant");
         };
@@ -255,7 +255,7 @@ matrix:
                     dimensions: LoE::Literal(dims),
                 })),
             ..
-        } = serde_yaml::from_str::<Strategy>(strategy).unwrap()
+        } = yaml_serde::from_str::<Strategy>(strategy).unwrap()
         else {
             panic!("unexpected matrix variant");
         };
@@ -268,7 +268,7 @@ matrix:
         let runson = "group: \nlabels: []";
 
         assert_eq!(
-            serde_yaml::from_str::<RunsOn>(runson)
+            yaml_serde::from_str::<RunsOn>(runson)
                 .unwrap_err()
                 .to_string(),
             "runs-on must provide either `group` or one or more `labels`"

crates/github-actions-models/src/workflow/mod.rs

@@ -122,11 +122,11 @@ mod tests {
     #[test]
     fn test_concurrency() {
         let bare = "foo";
-        let concurrency: Concurrency = serde_yaml::from_str(bare).unwrap();
+        let concurrency: Concurrency = yaml_serde::from_str(bare).unwrap();
         assert!(matches!(concurrency, Concurrency::Bare(_)));
 
         let rich = "group: foo\ncancel-in-progress: true";
-        let concurrency: Concurrency = serde_yaml::from_str(rich).unwrap();
+        let concurrency: Concurrency = yaml_serde::from_str(rich).unwrap();
         assert!(matches!(
             concurrency,
             Concurrency::Rich {
@@ -151,7 +151,7 @@ mod tests {
   pull_request_target:
         ";
 
-        let trigger: Trigger = serde_yaml::from_str(on).unwrap();
+        let trigger: Trigger = yaml_serde::from_str(on).unwrap();
         let Trigger::Events(events) = trigger else {
             panic!("wrong trigger type");
         };

crates/github-actions-models/tests/test_action.rs

@@ -10,7 +10,7 @@ fn load_action(name: &str) -> Action {
         .join("tests/sample-actions")
         .join(name);
     let action_contents = std::fs::read_to_string(action_path).unwrap();
-    serde_yaml::from_str(&action_contents).unwrap()
+    yaml_serde::from_str(&action_contents).unwrap()
 }
 
 #[test]
@@ -20,7 +20,7 @@ fn test_load_all() {
     for sample_action in std::fs::read_dir(sample_actions).unwrap() {
         let sample_action = sample_action.unwrap().path();
         let action_contents = std::fs::read_to_string(sample_action).unwrap();
-        serde_yaml::from_str::<Action>(&action_contents).unwrap();
+        yaml_serde::from_str::<Action>(&action_contents).unwrap();
     }
 }