binding [nfc]: Make PackageInfo and *DeviceInfo constructors const

Author: rajveermalviya

lib/model/binding.dart

@@ -156,7 +156,7 @@ abstract class ZulipBinding {
 
 /// Like [device_info_plus.BaseDeviceInfo], but without things we don't use.
 abstract class BaseDeviceInfo {
-  BaseDeviceInfo();
+  const BaseDeviceInfo();
 }
 
 /// Like [device_info_plus.AndroidDeviceInfo], but without things we don't use.
@@ -175,7 +175,7 @@ class AndroidDeviceInfo extends BaseDeviceInfo {
   ///   https://developer.android.com/reference/android/os/Build.VERSION_CODES.html
   final int sdkInt;
 
-  AndroidDeviceInfo({required this.release, required this.sdkInt});
+  const AndroidDeviceInfo({required this.release, required this.sdkInt});
 }
 
 /// Like [device_info_plus.IosDeviceInfo], but without things we don't use.
@@ -185,7 +185,7 @@ class IosDeviceInfo extends BaseDeviceInfo {
   /// See: https://developer.apple.com/documentation/uikit/uidevice/1620043-systemversion
   final String systemVersion;
 
-  IosDeviceInfo({required this.systemVersion});
+  const IosDeviceInfo({required this.systemVersion});
 }
 
 /// Like [device_info_plus.MacOsDeviceInfo], but without things we don't use.
@@ -199,7 +199,7 @@ class MacOsDeviceInfo extends BaseDeviceInfo {
   /// See: https://developer.apple.com/documentation/foundation/operatingsystemversion/1415564-patchversion
   final int patchVersion;
 
-  MacOsDeviceInfo({
+  const MacOsDeviceInfo({
     required this.majorVersion,
     required this.minorVersion,
     required this.patchVersion,
@@ -228,7 +228,9 @@ class MacOsDeviceInfo extends BaseDeviceInfo {
 //      makes it less ideal.
 //  [1]: https://gist.github.com/rajveermalviya/58b3add437280cc7f8356f3697099b7c
 //  [2]: https://github.com/zulip/zulip-flutter/pull/724#discussion_r1628318991
-class WindowsDeviceInfo implements BaseDeviceInfo {}
+class WindowsDeviceInfo implements BaseDeviceInfo {
+  const WindowsDeviceInfo();
+}
 
 /// Like [device_info_plus.LinuxDeviceInfo], but without things we don't use.
 class LinuxDeviceInfo implements BaseDeviceInfo {
@@ -249,15 +251,15 @@ class LinuxDeviceInfo implements BaseDeviceInfo {
   /// See: https://www.freedesktop.org/software/systemd/man/latest/os-release.html#VERSION_ID=
   final String? versionId;
 
-  LinuxDeviceInfo({required this.name, required this.versionId});
+  const LinuxDeviceInfo({required this.name, required this.versionId});
 }
 
 /// Like [package_info_plus.PackageInfo], but without things we don't use.
 class PackageInfo {
   final String version;
   final String buildNumber;
 
-  PackageInfo({
+  const PackageInfo({
     required this.version,
     required this.buildNumber,
   });
@@ -329,7 +331,7 @@ class LiveZulipBinding extends ZulipBinding {
         device_info_plus.MacOsDeviceInfo()   => MacOsDeviceInfo(majorVersion: info.majorVersion,
                                                                 minorVersion: info.minorVersion,
                                                                 patchVersion: info.patchVersion),
-        device_info_plus.WindowsDeviceInfo() => WindowsDeviceInfo(),
+        device_info_plus.WindowsDeviceInfo() => const WindowsDeviceInfo(),
         device_info_plus.LinuxDeviceInfo()   => LinuxDeviceInfo(name: info.name,
                                                                 versionId: info.versionId),
         _                                    => throw UnimplementedError(),

test/model/binding.dart

@@ -207,7 +207,7 @@ class TestZulipBinding extends ZulipBinding {
 
   /// The value that `ZulipBinding.instance.deviceInfo` should return.
   BaseDeviceInfo deviceInfoResult = _defaultDeviceInfoResult;
-  static final _defaultDeviceInfoResult = AndroidDeviceInfo(sdkInt: 33, release: '13');
+  static const _defaultDeviceInfoResult = AndroidDeviceInfo(sdkInt: 33, release: '13');
 
   void _resetDeviceInfo() {
     deviceInfoResult = _defaultDeviceInfoResult;
@@ -221,7 +221,7 @@ class TestZulipBinding extends ZulipBinding {
 
   /// The value that `ZulipBinding.instance.packageInfo` should return.
   PackageInfo packageInfoResult = _defaultPackageInfo;
-  static final _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
+  static const _defaultPackageInfo = PackageInfo(version: '0.0.1', buildNumber: '1');
 
   void _resetPackageInfo() {
     packageInfoResult = _defaultPackageInfo;

test/widgets/action_sheet_test.dart

@@ -415,7 +415,7 @@ void main() {
 
     testWidgets('can show snackbar on success', (tester) async {
       // Regression test for: https://github.com/zulip/zulip-flutter/issues/732
-      testBinding.deviceInfoResult = IosDeviceInfo(systemVersion: '16.0');
+      testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
 
       final message = eg.streamMessage();
       await setupToMessageActionSheet(tester, message: message, narrow: TopicNarrow.ofMessage(message));

test/widgets/clipboard_test.dart

@@ -58,21 +58,21 @@ void main() {
     }
 
     testWidgets('iOS', (WidgetTester tester) async {
-      testBinding.deviceInfoResult = IosDeviceInfo(systemVersion: '16.0');
+      testBinding.deviceInfoResult = const IosDeviceInfo(systemVersion: '16.0');
       await call(tester, text: 'asdf');
       await checkClipboardText('asdf');
       await checkSnackBar(tester, expected: true);
     });
 
     testWidgets('Android', (WidgetTester tester) async {
-      testBinding.deviceInfoResult = AndroidDeviceInfo(sdkInt: 33, release: '13');
+      testBinding.deviceInfoResult = const AndroidDeviceInfo(sdkInt: 33, release: '13');
       await call(tester, text: 'asdf');
       await checkClipboardText('asdf');
       await checkSnackBar(tester, expected: false);
     });
 
     testWidgets('Android <13', (WidgetTester tester) async {
-      testBinding.deviceInfoResult = AndroidDeviceInfo(sdkInt: 32, release: '12');
+      testBinding.deviceInfoResult = const AndroidDeviceInfo(sdkInt: 32, release: '12');
       await call(tester, text: 'asdf');
       await checkClipboardText('asdf');
       await checkSnackBar(tester, expected: true);