msglist [nfc]: Make narrow mutable for _MessageListPageState.

This allows us to switch narrow when a move happens.

Signed-off-by: Zixuan James Li <[email protected]>

Author: PIG208

integration_test/unreadmarker_test.dart

@@ -32,7 +32,7 @@ void main() {
       newestResult(foundOldest: true, messages: messages).toJson());
 
     await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
-      child: const MessageListPage(narrow: CombinedFeedNarrow())));
+      child: const MessageListPage(initNarrow: CombinedFeedNarrow())));
     await tester.pumpAndSettle();
     return messages;
   }

lib/notifications/display.dart

@@ -272,7 +272,7 @@ class NotificationDisplayManager {
     // TODO(nav): Better interact with existing nav stack on notif open
     navigator.push(MaterialAccountWidgetRoute<void>(accountId: account.id,
       // TODO(#82): Open at specific message, not just conversation
-      page: MessageListPage(narrow: narrow)));
+      page: MessageListPage(initNarrow: narrow)));
     return;
   }
 

lib/widgets/message_list.dart

@@ -191,12 +191,12 @@ abstract class MessageListPageState {
 }
 
 class MessageListPage extends StatefulWidget {
-  const MessageListPage({super.key, required this.narrow});
+  const MessageListPage({super.key, required this.initNarrow});
 
   static Route<void> buildRoute({int? accountId, BuildContext? context,
       required Narrow narrow}) {
     return MaterialAccountWidgetRoute(accountId: accountId, context: context,
-      page: MessageListPage(narrow: narrow));
+      page: MessageListPage(initNarrow: narrow));
   }
 
   /// The [MessageListPageState] above this context in the tree.
@@ -211,29 +211,35 @@ class MessageListPage extends StatefulWidget {
     return state!;
   }
 
-  final Narrow narrow;
+  final Narrow initNarrow;
 
   @override
   State<MessageListPage> createState() => _MessageListPageState();
 }
 
 class _MessageListPageState extends State<MessageListPage> implements MessageListPageState {
   @override
-  Narrow get narrow => widget.narrow;
+  late Narrow narrow;
 
   @override
   ComposeBoxController? get composeBoxController => _composeBoxKey.currentState;
 
   final GlobalKey<ComposeBoxController> _composeBoxKey = GlobalKey();
 
+  @override
+  void initState() {
+    super.initState();
+    narrow = widget.initNarrow;
+  }
+
   @override
   Widget build(BuildContext context) {
     final store = PerAccountStoreWidget.of(context);
     final messageListTheme = MessageListTheme.of(context);
 
     final Color? appBarBackgroundColor;
     bool removeAppBarBottomBorder = false;
-    switch(widget.narrow) {
+    switch(narrow) {
       case CombinedFeedNarrow():
       case MentionsNarrow():
         appBarBackgroundColor = null; // i.e., inherit
@@ -256,7 +262,7 @@ class _MessageListPageState extends State<MessageListPage> implements MessageLis
     }
 
     return Scaffold(
-      appBar: AppBar(title: MessageListAppBarTitle(narrow: widget.narrow),
+      appBar: AppBar(title: MessageListAppBarTitle(narrow: narrow),
         backgroundColor: appBarBackgroundColor,
         shape: removeAppBarBottomBorder
           ? const Border()
@@ -280,11 +286,11 @@ class _MessageListPageState extends State<MessageListPage> implements MessageLis
               // The compose box, when present, pads the bottom inset.
               // TODO(#311) If we have a bottom nav, it will pad the bottom
               //   inset, and this should always be true.
-              removeBottom: ComposeBox.hasComposeBox(widget.narrow),
+              removeBottom: ComposeBox.hasComposeBox(narrow),
 
               child: Expanded(
-                child: MessageList(narrow: widget.narrow))),
-            ComposeBox(controllerKey: _composeBoxKey, narrow: widget.narrow),
+                child: MessageList(narrow: narrow))),
+            ComposeBox(controllerKey: _composeBoxKey, narrow: narrow),
           ]))));
   }
 }

test/notifications/display_test.dart

@@ -546,7 +546,7 @@ void main() {
       route.isA<MaterialAccountWidgetRoute>()
         ..accountId.equals(account.id)
         ..page.isA<MessageListPage>()
-          .narrow.equals(SendableNarrow.ofMessage(message,
+          .initNarrow.equals(SendableNarrow.ofMessage(message,
             selfUserId: account.userId));
     }
 

test/widgets/action_sheet_test.dart

@@ -59,7 +59,7 @@ Future<void> setupToMessageActionSheet(WidgetTester tester, {
   ).toJson());
 
   await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
-    child: MessageListPage(narrow: narrow)));
+    child: MessageListPage(initNarrow: narrow)));
 
   // global store, per-account store, and message list get loaded
   await tester.pumpAndSettle();

test/widgets/autocomplete_test.dart

@@ -48,7 +48,7 @@ Future<Finder> setupToComposeInput(WidgetTester tester, {
   prepareBoringImageHttpClient();
 
   await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
-    child: MessageListPage(narrow: DmNarrow(
+    child: MessageListPage(initNarrow: DmNarrow(
       allRecipientIds: [eg.selfUser.userId, eg.otherUser.userId],
       selfUserId: eg.selfUser.userId))));
 

test/widgets/content_test.dart

@@ -815,7 +815,7 @@ void main() {
       await tapText(tester, find.text('stream'));
       check(testBinding.takeLaunchUrlCalls()).isEmpty();
       check(pushedRoutes).single.isA<WidgetRoute>()
-        .page.isA<MessageListPage>().narrow.equals(const ChannelNarrow(1));
+        .page.isA<MessageListPage>().initNarrow.equals(const ChannelNarrow(1));
     });
 
     testWidgets('invalid internal links are opened in browser', (tester) async {

test/widgets/message_list_checks.dart

@@ -3,5 +3,5 @@ import 'package:zulip/model/narrow.dart';
 import 'package:zulip/widgets/message_list.dart';
 
 extension MessageListPageChecks on Subject<MessageListPage> {
-  Subject<Narrow> get narrow => has((x) => x.narrow, 'narrow');
+  Subject<Narrow> get initNarrow => has((x) => x.initNarrow, 'initNarrow');
 }

test/widgets/message_list_test.dart

@@ -69,7 +69,7 @@ void main() {
       newestResult(foundOldest: foundOldest, messages: messages).toJson());
 
     await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
-      child: MessageListPage(narrow: narrow)));
+      child: MessageListPage(initNarrow: narrow)));
 
     // global store, per-account store, and message list get loaded
     await tester.pumpAndSettle();

test/widgets/profile_test.dart

@@ -251,7 +251,7 @@ void main() {
       await tester.tap(targetWidget);
       check(pushedRoutes).last.isA<WidgetRoute>().page
         .isA<MessageListPage>()
-        .narrow.equals(DmNarrow.withUser(1, selfUserId: eg.selfUser.userId));
+        .initNarrow.equals(DmNarrow.withUser(1, selfUserId: eg.selfUser.userId));
     });
 
     testWidgets('page builds; user links render multiple avatars', (WidgetTester tester) async {

test/widgets/recent_dm_conversations_test.dart

@@ -322,7 +322,7 @@ void main() {
 
         check(pushedRoutes).last.isA<WidgetRoute>().page
           .isA<MessageListPage>()
-          .narrow.equals(expectedNarrow);
+          .initNarrow.equals(expectedNarrow);
       }
 
       testWidgets('1:1', (WidgetTester tester) async {