Skip to content

Commit 363dafa

Browse files
committed
autocomplete test [nfc]: Cut unneeded MessageListView in end-to-end test
1 parent b436fb5 commit 363dafa

File tree

1 file changed

+2
-19
lines changed

1 file changed

+2
-19
lines changed

test/model/autocomplete_test.dart

Lines changed: 2 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,11 @@ import 'package:test/scaffolding.dart';
88
import 'package:zulip/api/model/initial_snapshot.dart';
99
import 'package:zulip/api/model/model.dart';
1010
import 'package:zulip/model/autocomplete.dart';
11-
import 'package:zulip/model/message_list.dart';
1211
import 'package:zulip/model/narrow.dart';
1312
import 'package:zulip/model/store.dart';
1413
import 'package:zulip/widgets/compose_box.dart';
1514

16-
import '../api/fake_api.dart';
1715
import '../example_data.dart' as eg;
18-
import 'message_list_test.dart';
1916
import 'test_store.dart';
2017
import 'autocomplete_checks.dart';
2118

@@ -575,16 +572,6 @@ void main() {
575572
});
576573

577574
test('final results end-to-end', () async {
578-
Future<void> fetchInitialMessagesIn(Narrow narrow, List<Message> messages) async {
579-
final connection = store.connection as FakeApiConnection;
580-
connection.prepare(json: newestResult(
581-
foundOldest: false,
582-
messages: messages,
583-
).toJson());
584-
final messageList = MessageListView.init(store: store, narrow: narrow);
585-
await messageList.fetchInitial();
586-
}
587-
588575
Future<Iterable<int>> getResults(
589576
Narrow narrow, MentionAutocompleteQuery query) async {
590577
bool done = false;
@@ -611,18 +598,14 @@ void main() {
611598
eg.user(userId: 5, fullName: 'User Five'),
612599
];
613600

614-
final messages = [
601+
await prepare(users: users, messages: [
615602
eg.streamMessage(id: 50, sender: users[1-1], stream: stream, topic: topic),
616603
eg.streamMessage(id: 60, sender: users[5-1], stream: stream),
617-
];
618-
619-
await prepare(users: users, messages: messages, dmConversations: [
604+
], dmConversations: [
620605
RecentDmConversation(userIds: [4], maxMessageId: 300),
621606
RecentDmConversation(userIds: [1], maxMessageId: 200),
622607
RecentDmConversation(userIds: [1, 2], maxMessageId: 100),
623608
]);
624-
await fetchInitialMessagesIn(topicNarrow,
625-
messages.where((m) => m.topic == topic).toList());
626609

627610
// Check the ranking of the full list of users.
628611
// The order should be:

0 commit comments

Comments
 (0)