Skip to content

Commit 739fa84

Browse files
committed
autocomplete test: Fix user IDs of zero
Zulip user IDs (like channel/stream IDs, message IDs, and so on) are positive integers. So avoiding zero helps keep the test data realistic.
1 parent 1e781dd commit 739fa84

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

test/model/autocomplete_test.dart

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -583,20 +583,20 @@ void main() {
583583
const topic = 'topic';
584584
final topicNarrow = TopicNarrow(stream.streamId, topic);
585585

586-
final users = List.generate(5, (i) => eg.user(userId: i));
586+
final users = List.generate(5, (i) => eg.user(userId: 1 + i));
587587

588588
final dmConversations = [
589-
RecentDmConversation(userIds: [3], maxMessageId: 300),
590-
RecentDmConversation(userIds: [0], maxMessageId: 200),
591-
RecentDmConversation(userIds: [0, 1], maxMessageId: 100),
589+
RecentDmConversation(userIds: [4], maxMessageId: 300),
590+
RecentDmConversation(userIds: [1], maxMessageId: 200),
591+
RecentDmConversation(userIds: [1, 2], maxMessageId: 100),
592592
];
593593

594594
StreamMessage streamMessage({required int id, required int senderId, String? topic}) =>
595-
eg.streamMessage(id: id, sender: users[senderId], topic: topic, stream: stream);
595+
eg.streamMessage(id: id, sender: users[senderId-1], topic: topic, stream: stream);
596596

597597
final messages = [
598-
streamMessage(id: 50, senderId: 0, topic: topic),
599-
streamMessage(id: 60, senderId: 4),
598+
streamMessage(id: 50, senderId: 1, topic: topic),
599+
streamMessage(id: 60, senderId: 5),
600600
];
601601

602602
Future<void> prepareStore() async {
@@ -629,7 +629,7 @@ void main() {
629629

630630
await prepareStore();
631631
await fetchInitialMessagesIn(topicNarrow);
632-
await checkResultsIn(topicNarrow, expected: [0, 4, 3, 1, 2]);
632+
await checkResultsIn(topicNarrow, expected: [1, 5, 4, 2, 3]);
633633
});
634634
});
635635
}

0 commit comments

Comments
 (0)