model [nfc]: Comment on lack of [AutocompleteViewManager.dispose]

chrisbobbe · chrisbobbe · commit 7dd19bbdd72a · 2024-05-06T14:00:16.000-07:00
diff --git a/lib/model/autocomplete.dart b/lib/model/autocomplete.dart
@@ -154,6 +154,12 @@ class AutocompleteViewManager {
       view.reassemble();
     }
   }
+
+  // `dispose`? Hmm, no: we already have code calling `dispose` on the views in
+  // [_mentionAutocompleteViews] when the [PerAccountStore] is replaced.
+  // It's UI code, a [PerAccountStoreAwareStateMixin.onNewStore], and it would
+  // be an error to call a [ChangeNotifier]'s dispose method twice. Discussion:
+  //   https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292
 }
 
 /// A view-model for a mention-autocomplete interaction.

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,12 @@ class AutocompleteViewManager {`
`154`	`154`	`view.reassemble();`
`155`	`155`	`}`
`156`	`156`	`}`
	`157`	`+`
	`158`	+ // `dispose`? Hmm, no: we already have code calling `dispose` on the views in
	`159`	`+ // [_mentionAutocompleteViews] when the [PerAccountStore] is replaced.`
	`160`	`+ // It's UI code, a [PerAccountStoreAwareStateMixin.onNewStore], and it would`
	`161`	`+ // be an error to call a [ChangeNotifier]'s dispose method twice. Discussion:`
	`162`	`+ // https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.60MentionAutocompleteView.2Edispose.60/near/1791292`
`157`	`163`	`}`
`158`	`164`
`159`	`165`	`/// A view-model for a mention-autocomplete interaction.`