store: Update account record from initial snapshot

Fixes: #458

Author: gnprice

lib/model/store.dart

@@ -2,6 +2,7 @@ import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:drift/drift.dart';
 import 'package:drift/native.dart';
 import 'package:flutter/foundation.dart';
 import 'package:path/path.dart' as p;
@@ -630,14 +631,25 @@ class UpdateMachine {
   ///
   /// In the future this might load an old snapshot from local storage first.
   static Future<UpdateMachine> load(GlobalStore globalStore, int accountId) async {
-    final account = globalStore.getAccount(accountId)!;
+    Account account = globalStore.getAccount(accountId)!;
     final connection = globalStore.apiConnectionFromAccount(account);
 
     final stopwatch = Stopwatch()..start();
     final initialSnapshot = await _registerQueueWithRetry(connection);
     final t = (stopwatch..stop()).elapsed;
     assert(debugLog("initial fetch time: ${t.inMilliseconds}ms"));
 
+    if (initialSnapshot.zulipVersion != account.zulipVersion
+        || initialSnapshot.zulipMergeBase != account.zulipMergeBase
+        || initialSnapshot.zulipFeatureLevel != account.zulipFeatureLevel) {
+      account = await globalStore.updateAccount(accountId, AccountsCompanion(
+        zulipVersion: Value(initialSnapshot.zulipVersion),
+        zulipMergeBase: Value(initialSnapshot.zulipMergeBase),
+        zulipFeatureLevel: Value(initialSnapshot.zulipFeatureLevel),
+      ));
+      connection.zulipFeatureLevel = initialSnapshot.zulipFeatureLevel;
+    }
+
     final store = PerAccountStore.fromInitialSnapshot(
       globalStore: globalStore,
       accountId: accountId,

test/model/store_test.dart

@@ -17,6 +17,7 @@ import '../example_data.dart' as eg;
 import '../fake_async.dart';
 import '../stdlib_checks.dart';
 import 'binding.dart';
+import 'store_checks.dart';
 import 'test_store.dart';
 
 void main() {
@@ -187,10 +188,11 @@ void main() {
     late TestGlobalStore globalStore;
     late FakeApiConnection connection;
 
-    Future<void> prepareStore() async {
+    Future<void> prepareStore({Account? account}) async {
       globalStore = TestGlobalStore(accounts: []);
-      await globalStore.insertAccount(eg.selfAccount.toCompanion(false));
-      connection = (globalStore.apiConnectionFromAccount(eg.selfAccount)
+      account ??= eg.selfAccount;
+      await globalStore.insertAccount(account.toCompanion(false));
+      connection = (globalStore.apiConnectionFromAccount(account)
         as FakeApiConnection);
       UpdateMachine.debugEnableRegisterNotificationToken = false;
       addTearDown(() => UpdateMachine.debugEnableRegisterNotificationToken = true);
@@ -220,6 +222,32 @@ void main() {
         users.map((expected) => (it) => it.fullName.equals(expected.fullName)));
     }));
 
+    test('updates account from snapshot', () => awaitFakeAsync((async) async {
+      final account = eg.account(user: eg.selfUser,
+        zulipVersion: '6.0+gabcd',
+        zulipMergeBase: '6.0',
+        zulipFeatureLevel: 123,
+      );
+      await prepareStore(account: account);
+      check(globalStore.getAccount(account.id)).isNotNull()
+        ..zulipVersion.equals('6.0+gabcd')
+        ..zulipMergeBase.equals('6.0')
+        ..zulipFeatureLevel.equals(123);
+
+      connection.prepare(json: eg.initialSnapshot(
+        zulipVersion: '8.0+g9876',
+        zulipMergeBase: '8.0',
+        zulipFeatureLevel: 234,
+      ).toJson());
+      final updateMachine = await UpdateMachine.load(globalStore, account.id);
+      updateMachine.debugPauseLoop();
+      check(globalStore.getAccount(account.id)).isNotNull()
+        ..identicalTo(updateMachine.store.account)
+        ..zulipVersion.equals('8.0+g9876')
+        ..zulipMergeBase.equals('8.0')
+        ..zulipFeatureLevel.equals(234);
+    }));
+
     test('retries registerQueue on NetworkError', () => awaitFakeAsync((async) async {
       await prepareStore();