Skip to content

Commit c5f3103

Browse files
committed
wip
Signed-off-by: Zixuan James Li <[email protected]>
1 parent b8516c5 commit c5f3103

File tree

5 files changed

+65
-17
lines changed

5 files changed

+65
-17
lines changed

lib/model/content.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,17 @@ mixin UnimplementedNode on ContentNode {
7272
}
7373
}
7474

75+
sealed class ZulipMessageContent {}
76+
77+
class PollContent implements ZulipMessageContent {}
78+
7579
/// A complete parse tree for a Zulip message's content,
7680
/// or other complete piece of Zulip HTML content.
7781
///
7882
/// This is a parsed representation for an entire value of [Message.content],
7983
/// [Stream.renderedDescription], or other text from a Zulip server that comes
8084
/// in the same Zulip HTML format.
81-
class ZulipContent extends ContentNode {
85+
class ZulipContent extends ContentNode implements ZulipMessageContent {
8286
const ZulipContent({super.debugHtmlNode, required this.nodes});
8387

8488
final List<BlockContentNode> nodes;

lib/model/message_list.dart

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class MessageListDateSeparatorItem extends MessageListItem {
3434
/// A message to show in the message list.
3535
class MessageListMessageItem extends MessageListItem {
3636
final Message message;
37-
ZulipContent content;
37+
ZulipMessageContent content;
3838
bool showSender;
3939
bool isLastInBlock;
4040

@@ -94,7 +94,7 @@ mixin _MessageSequence {
9494
///
9595
/// This information is completely derived from [messages].
9696
/// It exists as an optimization, to memoize the work of parsing.
97-
final List<ZulipContent> contents = [];
97+
final List<ZulipMessageContent> contents = [];
9898

9999
/// The messages and their siblings in the UI, in order.
100100
///
@@ -130,10 +130,18 @@ mixin _MessageSequence {
130130
}
131131
}
132132

133+
ZulipMessageContent _parseMessage(Message message) {
134+
if (message.poll != null) {
135+
return PollContent();
136+
} else {
137+
return parseContent(message.content);
138+
}
139+
}
140+
133141
/// Update data derived from the content of the index-th message.
134142
void _reparseContent(int index) {
135143
final message = messages[index];
136-
final content = parseContent(message.content);
144+
final content = _parseMessage(message);
137145
contents[index] = content;
138146

139147
final itemIndex = findItemWithMessageId(message.id);
@@ -150,7 +158,7 @@ mixin _MessageSequence {
150158
void _addMessage(Message message) {
151159
assert(contents.length == messages.length);
152160
messages.add(message);
153-
contents.add(parseContent(message.content));
161+
contents.add(_parseMessage(message));
154162
assert(contents.length == messages.length);
155163
_processMessage(messages.length - 1);
156164
}
@@ -161,7 +169,7 @@ mixin _MessageSequence {
161169
/// If none of [messageIds] are found, this is a no-op.
162170
bool _removeMessagesById(Iterable<int> messageIds) {
163171
final messagesToRemoveById = <int>{};
164-
final contentToRemove = Set<ZulipContent>.identity();
172+
final contentToRemove = Set<ZulipMessageContent>.identity();
165173
for (final messageId in messageIds) {
166174
final index = _findMessageWithId(messageId);
167175
if (index == -1) continue;
@@ -187,7 +195,7 @@ mixin _MessageSequence {
187195
assert(contents.length == messages.length);
188196
messages.insertAll(index, toInsert);
189197
contents.insertAll(index, toInsert.map(
190-
(message) => parseContent(message.content)));
198+
(message) => _parseMessage(message)));
191199
assert(contents.length == messages.length);
192200
_reprocessAll();
193201
}
@@ -196,7 +204,7 @@ mixin _MessageSequence {
196204
void _recompute() {
197205
assert(contents.length == messages.length);
198206
contents.clear();
199-
contents.addAll(messages.map((message) => parseContent(message.content)));
207+
contents.addAll(messages.map((message) => _parseMessage(message)));
200208
assert(contents.length == messages.length);
201209
_reprocessAll();
202210
}

lib/widgets/content.dart

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import 'dialog.dart';
1818
import 'icons.dart';
1919
import 'lightbox.dart';
2020
import 'message_list.dart';
21+
import 'poll.dart';
2122
import 'store.dart';
2223
import 'text.dart';
2324

@@ -222,17 +223,20 @@ const double kBaseFontSize = 17;
222223
/// This does not include metadata like the sender's name and avatar, the time,
223224
/// or the message's status as starred or edited.
224225
class MessageContent extends StatelessWidget {
225-
const MessageContent({super.key, required this.message, required this.content});
226+
const MessageContent({super.key, required this.message, required ZulipMessageContent content}) : _content = content;
226227

227228
final Message message;
228-
final ZulipContent content;
229+
final ZulipMessageContent _content;
229230

230231
@override
231232
Widget build(BuildContext context) {
232233
return InheritedMessage(message: message,
233234
child: DefaultTextStyle(
234235
style: ContentTheme.of(context).textStylePlainParagraph,
235-
child: BlockContentList(nodes: content.nodes)));
236+
child: switch(_content) {
237+
ZulipContent() => BlockContentList(nodes: _content.nodes),
238+
PollContent() => PollWidget(message: message),
239+
}));
236240
}
237241
}
238242

lib/widgets/poll.dart

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
import 'package:flutter/material.dart';
2+
3+
import '../api/model/model.dart';
4+
import '../api/model/submessage.dart';
5+
import '../model/content.dart';
6+
import 'content.dart';
7+
import 'store.dart';
8+
9+
class PollWidget extends StatelessWidget {
10+
const PollWidget({super.key, required this.message});
11+
12+
final Message message;
13+
14+
@override
15+
Widget build(BuildContext context) {
16+
final store = PerAccountStoreWidget.of(context);
17+
Poll? poll = message.poll;
18+
if (poll == null) return const Text('no poll');
19+
20+
return Column(
21+
children: [
22+
Heading(node: HeadingNode(level: HeadingLevel.h1, links: null, nodes: [TextNode(poll.question)])),
23+
for (final option in poll.options)
24+
Paragraph(node: ParagraphNode(links: null, nodes: [
25+
TextNode('${option.text} ${option.voters.length} Votes: '),
26+
const LineBreakInlineNode(),
27+
TextNode(option.voters.map((userId) => store.users[userId]?.fullName).where((user) => user != null).join(','))
28+
]))
29+
],
30+
);
31+
}
32+
}

test/model/message_list_test.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -543,12 +543,12 @@ void main() {
543543
model.contents[0] = const ZulipContent(nodes: [
544544
ParagraphNode(links: null, nodes: [TextNode('something outdated')])
545545
]);
546-
check(model.contents[0]).not((it) => it.equalsNode(correctContent));
546+
check(model.contents[0] as ZulipContent).not((it) => it.equalsNode(correctContent));
547547

548548
model.reassemble();
549549
checkNotifiedOnce();
550550
check(model).messages.length.equals(31);
551-
check(model.contents[0]).equalsNode(correctContent);
551+
check(model.contents[0] as ZulipContent).equalsNode(correctContent);
552552
});
553553

554554
group('stream/topic muting', () {
@@ -946,7 +946,7 @@ void checkInvariants(MessageListView model) {
946946

947947
check(model).contents.length.equals(model.messages.length);
948948
for (int i = 0; i < model.contents.length; i++) {
949-
check(model.contents[i])
949+
check(model.contents[i] as ZulipContent)
950950
.equalsNode(parseContent(model.messages[i].content));
951951
}
952952

@@ -971,7 +971,7 @@ void checkInvariants(MessageListView model) {
971971
}
972972
check(model.items[i++]).isA<MessageListMessageItem>()
973973
..message.identicalTo(model.messages[j])
974-
..content.identicalTo(model.contents[j])
974+
..content.identicalTo(model.contents[j] as ZulipContent)
975975
..showSender.equals(
976976
forcedShowSender || model.messages[j].senderId != model.messages[j-1].senderId)
977977
..isLastInBlock.equals(
@@ -996,7 +996,7 @@ extension MessageListDateSeparatorItemChecks on Subject<MessageListDateSeparator
996996

997997
extension MessageListMessageItemChecks on Subject<MessageListMessageItem> {
998998
Subject<Message> get message => has((x) => x.message, 'message');
999-
Subject<ZulipContent> get content => has((x) => x.content, 'content');
999+
Subject<ZulipContent> get content => has((x) => x.content as ZulipContent, 'content');
10001000
Subject<bool> get showSender => has((x) => x.showSender, 'showSender');
10011001
Subject<bool> get isLastInBlock => has((x) => x.isLastInBlock, 'isLastInBlock');
10021002
}
@@ -1005,7 +1005,7 @@ extension MessageListViewChecks on Subject<MessageListView> {
10051005
Subject<PerAccountStore> get store => has((x) => x.store, 'store');
10061006
Subject<Narrow> get narrow => has((x) => x.narrow, 'narrow');
10071007
Subject<List<Message>> get messages => has((x) => x.messages, 'messages');
1008-
Subject<List<ZulipContent>> get contents => has((x) => x.contents, 'contents');
1008+
Subject<List<ZulipContent>> get contents => has((x) => x.contents as List<ZulipContent>, 'contents');
10091009
Subject<List<MessageListItem>> get items => has((x) => x.items, 'items');
10101010
Subject<bool> get fetched => has((x) => x.fetched, 'fetched');
10111011
Subject<bool> get haveOldest => has((x) => x.haveOldest, 'haveOldest');

0 commit comments

Comments
 (0)