Skip to content

Commit d12d75e

Browse files
committed
unread_count_badge: Comment on some overlooked uncertainty in text color
1 parent ffb924e commit d12d75e

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

lib/widgets/unread_count_badge.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,16 @@ class UnreadCountBadge extends StatelessWidget {
4949
fontSize: 16,
5050
height: (18 / 16),
5151
fontFeatures: [FontFeature.enable('smcp')], // small caps
52+
53+
// From the Figma:
54+
// https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=171-12359&mode=design&t=JKrw76SGUF51nSJG-0
55+
// TODO or, when background is stream-colored, follow Vlad's replit:
56+
// https://replit.com/@VladKorobov/zulip-sidebar#script.js
57+
// which means:
58+
// - in light mode use `Color.fromRGBO(0, 0, 0, 0.9)`
59+
// - in dark mode use `Color.fromRGBO(255, 255, 255, 0.9)`
60+
// The web app doesn't (yet?) use stream-colored unread markers
61+
// so we can't take direction from there.
5262
color: Color(0xFF222222),
5363
).merge(weightVariableTextStyle(context,
5464
wght: bold ? 600 : null)),

0 commit comments

Comments
 (0)