login: Store realmName and realmIcon while creating account

Author: rajveermalviya

lib/widgets/login.dart

@@ -406,6 +406,10 @@ class _LoginPageState extends State<LoginPage> {
     try {
       accountId = await globalStore.insertAccount(AccountsCompanion.insert(
         realmUrl: realmUrl,
+        // TODO store the updated value from /register
+        realmName: Value(widget.serverSettings.realmName),
+        // TODO store the updated value from /register
+        realmIcon: Value(widget.serverSettings.realmIcon),
         email: email,
         apiKey: apiKey,
         userId: userId,

test/widgets/login_test.dart

@@ -1,7 +1,6 @@
 import 'dart:async';
 
 import 'package:checks/checks.dart';
-import 'package:drift/drift.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
@@ -11,8 +10,8 @@ import 'package:zulip/api/model/web_auth.dart';
 import 'package:zulip/api/route/account.dart';
 import 'package:zulip/api/route/realm.dart';
 import 'package:zulip/model/binding.dart';
-import 'package:zulip/model/database.dart';
 import 'package:zulip/model/localizations.dart';
+import 'package:zulip/model/store.dart';
 import 'package:zulip/widgets/app.dart';
 import 'package:zulip/widgets/home.dart';
 import 'package:zulip/widgets/login.dart';
@@ -258,11 +257,7 @@ void main() {
         await login(tester, eg.selfAccount);
         check(testBinding.globalStore.accounts).single
           .equals(eg.selfAccount.copyWith(
-            id: testBinding.globalStore.accounts.single.id,
-            // TODO store value from server settings during login flow
-            realmName: Value(null),
-            // TODO store value from server settings during login flow
-            realmIcon: Value(null)));
+            id: testBinding.globalStore.accounts.single.id));
       });
 
       testWidgets('logging into a second account', (tester) async {
@@ -279,12 +274,7 @@ void main() {
         await login(tester, eg.otherAccount);
         final newAccount = testBinding.globalStore.accounts.singleWhere(
           (account) => account != eg.selfAccount);
-        check(newAccount).equals(eg.otherAccount.copyWith(
-          id: newAccount.id,
-          // TODO store value from server settings during login flow
-          realmName: Value(null),
-          // TODO store value from server settings during login flow
-          realmIcon: Value(null)));
+        check(newAccount).equals(eg.otherAccount.copyWith(id: newAccount.id));
         check(poppedRoutes).length.equals(2);
         check(pushedRoutes).single.isA<WidgetRoute>().page.isA<HomePage>();
       });
@@ -309,11 +299,7 @@ void main() {
         await tester.idle();
         check(testBinding.globalStore.accounts).single
           .equals(eg.selfAccount.copyWith(
-            id: testBinding.globalStore.accounts.single.id,
-            // TODO store value from server settings during login flow
-            realmName: Value(null),
-            // TODO store value from server settings during login flow
-            realmIcon: Value(null)));
+            id: testBinding.globalStore.accounts.single.id));
       });
 
       testWidgets('account already exists', (tester) async {
@@ -340,6 +326,30 @@ void main() {
           expectedTitle: zulipLocalizations.errorAccountLoggedInTitle)));
       });
 
+      testWidgets('creates account with data from server settings', (tester) async {
+        final serverSettings = eg.serverSettings(
+          realmName: 'Some organization',
+          realmIcon: Uri.parse('/some-image.png'),
+          zulipFeatureLevel: 427,
+          zulipVersion: '12.0-dev-524-ga557b1e721',
+          zulipMergeBase: '12.0-dev-523-g72e3b94855',
+        );
+        await prepare(tester, serverSettings);
+        takeStartingRoutes();
+        check(pushedRoutes).isEmpty();
+        check(testBinding.globalStore.accounts).isEmpty();
+
+        await login(tester, eg.selfAccount);
+        check(testBinding.globalStore.accounts).single
+          .equals(eg.selfAccount.copyWith(
+            id: testBinding.globalStore.accounts.single.id,
+            realmName: Value('Some organization'),
+            realmIcon: Value(Uri.parse('/some-image.png')),
+            zulipFeatureLevel: 427,
+            zulipVersion: '12.0-dev-524-ga557b1e721',
+            zulipMergeBase: Value('12.0-dev-523-g72e3b94855')));
+      });
+
       // TODO test validators on the TextFormField widgets
       // TODO test _getUserId case
       // TODO test handling failure in fetchApiKey request
@@ -390,12 +400,7 @@ void main() {
         check(testBinding.takeCloseInAppWebViewCallCount()).equals(1);
 
         final account = testBinding.globalStore.accounts.single;
-        check(account).equals(eg.selfAccount.copyWith(
-          id: account.id,
-          // TODO store value from server settings during login flow
-          realmName: Value(null),
-          // TODO store value from server settings during login flow
-          realmIcon: Value(null)));
+        check(account).equals(eg.selfAccount.copyWith(id: account.id));
         check(pushedRoutes).single.isA<MaterialAccountWidgetRoute>()
           ..accountId.equals(account.id)
           ..page.isA<HomePage>();