Skip to content

Show counts in main menu and nav bar #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PIG208 opened this issue Nov 26, 2024 · 0 comments
Open

Show counts in main menu and nav bar #1088

PIG208 opened this issue Nov 26, 2024 · 0 comments
Labels
a-home The home screens of the app; finding and starting conversations a-model Implementing our data model (PerAccountStore, etc.)

Comments

@PIG208
Copy link
Member

PIG208 commented Nov 26, 2024

The design for the main menu and bottom nav bar (#1035) calls for showing message counts on many of the items: the number of unread DMs on the DMs item, the number of starred messages on the "Starred messages" item, and so on. This issue is for adding that feature.

Screenshot 00-menu iphone 14 pro

Implementation

The exact semantics of whether a given item has a number shown on it, and what that number should be, should match the web app's left sidebar.

For computing the values to be shown: generally we should avoid doing significant computation in the widgets' build methods. Instead, use the Unreads model, or potentially introduce a view-model for efficiently maintaining whatever additional information we might need for some of these items.

For how to organize this feature in the widgets code:

Maybe a good structure for that is a method like Widget? buildTrailing(BuildContext context) [on the _MenuButton class in lib/widgets/home.dart]. Then most subclasses will return a _MenuItemCounter, or null; but e.g. the "Notifications" row (in the future! […]) can return that yellow warning icon.

@gnprice gnprice added this to the M6: Post-launch milestone Nov 26, 2024
@gnprice gnprice added a-home The home screens of the app; finding and starting conversations a-model Implementing our data model (PerAccountStore, etc.) labels Nov 26, 2024
@gnprice gnprice changed the title Aggregate message-related unreads/quantity information and display them Show counts in main menu Feb 19, 2025
@gnprice gnprice changed the title Show counts in main menu Show counts in main menu and nav bar Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-home The home screens of the app; finding and starting conversations a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: No status
Development

No branches or pull requests

2 participants