Skip to content

Update recent-DMs data on fetching messages #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue May 8, 2024 · 0 comments
Open

Update recent-DMs data on fetching messages #650

gnprice opened this issue May 8, 2024 · 0 comments
Labels
a-model Implementing our data model (PerAccountStore, etc.)

Comments

@gnprice
Copy link
Member

gnprice commented May 8, 2024

When a new message comes in, we update the RecentDmConversationsView data structure. But when we go and fetch a bunch of messages for a message list, we don't.

Mostly this works out, because the initial snapshot has an unreads digest that already covers the most recent DM conversations, up to a large number of recent messages. But if you go look at some history that includes a long-inactive DM conversation —say, you follow a link to such a conversation — we'll end up with a DM conversation we have some messages from but that doesn't appear in the list of recent DM conversations, in particular the corresponding screen in the UI. That's odd and would be good to fix.

This will most naturally come after a central message store, #648 / #455.

Similar to #649. This issue and that one can be done in any order.

Milestoned post-launch; we do currently do this in zulip-mobile, but I suspect few users will notice if we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-model Implementing our data model (PerAccountStore, etc.)
Projects
Status: No status
Development

No branches or pull requests

1 participant