Skip to content

Commit 1b03037

Browse files
committed
avatar [nfc]: Simplify comment on missing rawAvatarUrl, for Zulip 1.9+
1 parent 43f8b7a commit 1b03037

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

src/utils/avatar.js

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,12 @@ export class AvatarURL {
3434
|}): AvatarURL {
3535
const { rawAvatarUrl, userId, email, realm } = args;
3636
if (rawAvatarUrl === undefined) {
37-
// New in Zulip 3.0, feature level 18, the field may be missing
38-
// on user objects in the register response, at the server's
39-
// discretion, if we announce the
40-
// `user_avatar_url_field_optional` client capability, which we
41-
// do. See the note about `user_avatar_url_field_optional` at
42-
// https://zulip.com/api/register-queue.
37+
// New in Zulip 3.0, feature level 18, the field may be missing on
38+
// user objects in the register response, at the server's discretion,
39+
// if we announce the `user_avatar_url_field_optional` client
40+
// capability, which we do. See `user_avatar_url_field_optional` at:
41+
// https://zulip.com/api/register-queue
4342
//
44-
// It will also be absent on cross-realm bots from servers prior
45-
// to 58ee3fa8c (1.9.0). The effect of using FallbackAvatarURL for
46-
// this case isn't thoroughly considered, but at worst, it means a
47-
// 404. We could plumb through the server version and
48-
// conditionalize on that.
49-
//
50-
// TODO(server-1.9): Simplify this comment.
5143
// TODO(server-3.0): Simplify this comment.
5244
return FallbackAvatarURL.validateAndConstructInstance({ realm, userId });
5345
} else if (rawAvatarUrl === null) {

0 commit comments

Comments
 (0)