Skip to content

Commit 8171f2d

Browse files
committed
outbox types [nfc]: Fix TODO comment on adding stream_id.
The key step that needs to be out in a release for a bit before we drop outbox messages that lack this property isn't that we have our type annotations permit it -- but that we actually start putting it into new outbox messages that we create ;-) .
1 parent 6fe63e3 commit 8171f2d

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/types.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,11 @@ export type PmOutbox = $ReadOnly<{|
203203
export type StreamOutbox = $ReadOnly<{|
204204
...OutboxBase,
205205

206-
// TODO(#3764): Make stream_id required. Needs a migration to drop
207-
// StreamOutbox values that lack it; that'll be fine once the
208-
// release that adds it has been out for a few weeks. (Also drop
209-
// the hack line about it in MessageLike.)
206+
// TODO(#3764): Make stream_id required. First need to start supplying it
207+
// in the Outbox values we create; compare a1fad7ca9, for sender_id.
210208
//
211-
// Once it is required, it
212-
// should go in the second type argument passed to
213-
// `SubsetProperties` of `StreamMessage`, below.
209+
// Once it is required, it should move from here to the second type
210+
// argument passed to `SubsetProperties` of `StreamMessage`, below.
214211
stream_id?: number,
215212

216213
...SubsetProperties<StreamMessage, {||}>,

0 commit comments

Comments
 (0)