user selectors [nfc]: Refactor 'getUserIsActive' to accept user ID.

We are migrating the codebase from emails to user IDs to identify
users, because user IDs are more reliable.

Author: agrawal-d

src/account-info/AccountDetailsScreen.js

@@ -89,11 +89,5 @@ class AccountDetailsScreen extends PureComponent<Props> {
 
 export default connect<SelectorProps, _, _>((state, props) => ({
   user: getAllUsersById(state).get(props.navigation.state.params.userId),
-  isActive: (() => {
-    const user = getAllUsersById(state).get(props.navigation.state.params.userId);
-    if (!user) {
-      return false;
-    }
-    return getUserIsActive(state, user.email);
-  })(),
+  isActive: getUserIsActive(state, props.navigation.state.params.userId),
 }))(AccountDetailsScreen);

src/users/__tests__/userSelectors-test.js

@@ -137,14 +137,14 @@ describe('getUserIsActive', () => {
   });
 
   test('returns false for a user that has been deactivated', () => {
-    expect(getUserIsActive(state, state.realm.nonActiveUsers[0].email)).toBeFalse();
+    expect(getUserIsActive(state, state.realm.nonActiveUsers[0].user_id)).toBeFalse();
   });
 
   test('returns true for a user that has not been deactivated', () => {
-    expect(getUserIsActive(state, state.users[0].email)).toBeTrue();
+    expect(getUserIsActive(state, state.users[0].user_id)).toBeTrue();
   });
 
   test('returns true for a cross realm bot', () => {
-    expect(getUserIsActive(state, state.realm.crossRealmBots[0].email)).toBeTrue();
+    expect(getUserIsActive(state, state.realm.crossRealmBots[0].user_id)).toBeTrue();
   });
 });

src/users/userSelectors.js

@@ -201,9 +201,7 @@ export const getAccountDetailsUserForEmail: Selector<UserOrBot, string> = create
  */
 // To understand this implementation, see the comment about `is_active` in
 // the `User` type definition.
-export const getUserIsActive = (state: GlobalState, email: string): boolean => {
-  if (!email) {
-    return false;
-  }
-  return getActiveUsersByEmail(state).has(email);
+export const getUserIsActive = (state: GlobalState, userId: number): boolean => {
+  const activeUserIds = [...getUsers(state), ...getCrossRealmBots(state)].map(user => user.user_id);
+  return activeUserIds.includes(userId);
 };