ActionSheet [nfc]: Parameterize some values used in tests.

This is better since most of these things are / can-be reused in
the test suite of concern, and it is easy to change their values
should we choose to do so.

Author: AkashDhiman

src/message/__tests__/messageActionSheet-test.js

@@ -59,21 +59,25 @@ describe('constructActionButtons', () => {
 });
 
 describe('constructTopicActionButtons', () => {
+  const streamMessage = eg.streamMessage();
+  const streamName = streamNameOfStreamMessage(streamMessage);
+  const topic = streamMessage.subject;
+
   test('show Unmute topic option if topic is muted', () => {
-    const mute = deepFreeze([['electron issues', 'issue #556']]);
+    const mute = deepFreeze([[streamName, topic]]);
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, mute },
-      streamName: 'electron issues',
-      topic: 'issue #556',
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).toContain('Unmute topic');
   });
 
   test('show mute topic option if topic is not muted', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, mute: [] },
-      streamName: streamNameOfStreamMessage(eg.streamMessage()),
-      topic: eg.streamMessage().subject,
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).toContain('Mute topic');
   });
@@ -82,8 +86,8 @@ describe('constructTopicActionButtons', () => {
     const subscriptions = [{ ...eg.subscription, in_home_view: false }];
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, subscriptions },
-      streamName: streamNameOfStreamMessage(eg.streamMessage()),
-      topic: eg.streamMessage().subject,
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).toContain('Unmute stream');
   });
@@ -92,8 +96,8 @@ describe('constructTopicActionButtons', () => {
     const subscriptions = [{ ...eg.subscription, in_home_view: true }];
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, subscriptions },
-      streamName: streamNameOfStreamMessage(eg.streamMessage()),
-      topic: eg.streamMessage().subject,
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).toContain('Mute stream');
   });
@@ -102,17 +106,17 @@ describe('constructTopicActionButtons', () => {
     const ownUser = { ...eg.selfUser, is_admin: true };
     const buttons = constructTopicActionButtons({
       backgroundData: { ...baseBackgroundData, ownUser },
-      streamName: streamNameOfStreamMessage(eg.streamMessage()),
-      topic: eg.streamMessage().subject,
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).toContain('Delete topic');
   });
 
   test('do not show delete topic option if current user is not an admin', () => {
     const buttons = constructTopicActionButtons({
       backgroundData: baseBackgroundData,
-      streamName: streamNameOfStreamMessage(eg.streamMessage()),
-      topic: eg.streamMessage().subject,
+      streamName,
+      topic,
     });
     expect(buttonTitles(buttons)).not.toContain('Delete topic');
   });