Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47ec1f4020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <View style={styles.listContent}> | ||
| {data.map((item) => { |
There was a problem hiding this comment.
Replacing FlatList with ScrollView + data.map removes virtualization, so every participant row is mounted and kept in memory at once. In larger rooms (for example, webinars or classes with many attendees), opening this panel will now do O(n) render work immediately and can cause noticeable jank or dropped frames on lower-end devices; the previous FlatList avoided this by rendering only visible rows.
Useful? React with 👍 / 👎.
| <FlatList | ||
| ref={listRef} | ||
| data={messages} | ||
| data={[...messages].reverse()} |
There was a problem hiding this comment.
Building data inline with [...messages].reverse() creates a brand-new array each render, so unrelated state updates (like typing in the input) still make FlatList treat the dataset as changed and reprocess rows. In active chats with long histories, this adds unnecessary O(n) work per keystroke and can lead to scroll/typing lag; memoizing the reversed list by messages would preserve performance.
Useful? React with 👍 / 👎.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
No description provided.