Experiment towards sync#11459
Closed
erights wants to merge 3 commits into
Closed
Conversation
erights
changed the base branch from
master
to
kris-sync-endo-2025-06-06-01-23-47
Deploying agoric-sdk with
|
| Latest commit: |
fe707b0
|
| Status: | 🚫 Build failed. |
kriskowal
force-pushed
the
kris-sync-endo-2025-06-06-01-23-47
branch
3 times, most recently
from
35bd61d to
e5d2354
Compare
erights
force-pushed
the
markm-experiment-towards-sync
branch
from
d11697a to
ab52af4
Compare
erights
added a commit
that referenced
this pull request
Jun 16, 2025
This was referenced Jun 16, 2025
erights
added a commit
that referenced
this pull request
Jun 16, 2025
Member
Author
|
experiment not currently actionable. Closing. |
erights
added a commit
to endojs/endo
that referenced
this pull request
Jun 24, 2025
Closes: #XXXX Refs: Agoric/agoric-sdk#11497 ## Description Experiment with possible endo speedups. This was originally motivated to try for fewer benchmark errors in Agoric/agoric-sdk#11497 vs Agoric/agoric-sdk#11459 . However, the relevant bottleneck for those, while still not diagnosed, is not addressed or affected by this PR. Nevertheless, according to @gibson042 's comment at #2860 (review) below > This change has minor impact in V8, but Object(value) must be very slow in XS because the speedup there is significant. Since we care most of all about performance in XS, this change is worth it. ### Security Considerations none ### Scaling Considerations No change to complexity measure, so no change to "scaling" per se. But more colloquially, we include in "scaling" a significant performance improvement. ### Documentation Considerations In light of @gibson042 's suggestion below, this PR will deprecate `isObject`, export `isPrimitive` as the inverted replacement, because the name is clearer, and will switch all current callers of `isObject` to call `isPrimitive` instead. This should be reflected in the generated typedoc commentary. ### Testing Considerations None. ### Compatibility Considerations Because we're only deprecating `isObject`, and because we make no change to its observable behavior, none. ### Upgrade Considerations - [ ] Update `NEWS.md` with `isPrimitive` and the deprecation of `isObject`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#endo-branch: master
Staged on #11451
closes: #XXXX
refs: #11451
Description
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations