feat(ymax-planner): Improve the "No feasible solution" error message for a graph with debug: true#12641
Merged
mergify[bot] merged 4 commits intomasterfrom Apr 28, 2026
Conversation
mhofman
approved these changes
Apr 27, 2026
Member
mhofman
left a comment
mhofman
left a comment
There was a problem hiding this comment.
The solver goes a bit over my head, but given the impact of this change, I'm willing to approve.
…ssetPlaceRef syntax
DepositFromChainRef: `+${ChainName}`
WithdrawToChainRef: `-${ChainName}`
…for a graph with debug: true * unquote the message * translate `e$nn` edge ids into `$src->$dest` labels * consolidate pick/via variable assignments for the same edge * sort edges by ascending id
…" error message Underscore-separate number literal digits into groups of 3 such that e.g. 10k uusdc looks like "10_000_000_000".
gibson042
force-pushed
the
gibson-2026-04-ymax-planner-solver-diagnostics
branch
from
c230bd8 to
b966e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
preflightValidateNetworkPlanabout new AssetPlaceRef syntax (DepositFromChainRef+${ChainName}and WithdrawToChainRef-${ChainName}) to avoid errors likeUnsupported position key: "+Ethereum"e$nnedge ids into$src->$destlabelsSecurity Considerations
None known
Scaling Considerations
The increased object and text manipulation is a negligible burden, and even so, only applies when the solver rejects a flow graph.
Documentation Considerations
n/a
Testing Considerations
Since these error messages are intended to be human-friendly, added test coverage for them.
Upgrade Considerations
Safe for immediate deployment.